From nobody Wed Jan 05 21:09:31 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 20C231922902 for ; Wed, 5 Jan 2022 21:09:44 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x932.google.com (mail-ua1-x932.google.com [IPv6:2607:f8b0:4864:20::932]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JThvB48bKz52wZ for ; Wed, 5 Jan 2022 21:09:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x932.google.com with SMTP id v12so761658uar.7 for ; Wed, 05 Jan 2022 13:09:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xTud95byqO1Yst+V3dwoRaWLJKK2bed+akpyp3gViZg=; b=ibQn1oTjGmqp+VK23Tb/VhxUczDXBeyqDXpVad7VLl8DslmhOCOG3n+/6XdmDDXQL4 Z72swYvkqliW/3C/9U48rhqTrzELdNt9UEa+JWJ+5u8QOJ1cRde35yvIZjh1b8KYIq5X P9l14f2/minThEZpXcuEeoPpxiAS6BR9IYyrMZtKLhBOwRtg8Nm8nTq1jxpNBIxA7sKX ZCiJbhS/swVP9p71FPpJ6oEV6+jE1EMT3yWBlw1eMxoDuJCd+HF+bv8G5pA5BUCx4LiF qu1q0H8qLIHxEkSwsOpllH31ZJ9BW244snD1HxL7cKECoZJw7Id3fGkdj5KkhH2vkQI5 nkmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xTud95byqO1Yst+V3dwoRaWLJKK2bed+akpyp3gViZg=; b=ENT4lH4t09cxRcNH2eawbgE6psbnfD3I6agED5uR1Lxrx6ADy0KjiyAOKG227LIQx4 ONdFrFZhHM5Rp1Ne0xtmanLURm+3TxjxNUA9d8l9gduGL8+VZvvXCjjmVeElg+hJeVYN GpySOhspBE/WIvnsqoAPMhjUivV7fkCsQGxnugQBThaZxgOrvntDBLuhMl3QKG941MNZ h7p7s+DgGowRRUhGaeT896wpg2+imNRBxfZbMVOErNSt4ToOm0oR6vFIfaLsVQ3cUHRv fKgzu4w2QGZUkVlg5fIhYR7K0eg50YOledhcU2V9htcIGbqYE+cxQ7PhUIFhM+eqCVsZ KVBw== X-Gm-Message-State: AOAM5320RuIyHbNjdzgUCcTYuYpBmEZ1bhE3ywDDG+EWCDdHAUXHt4VO r1O37YfEViiCfzentg6aFm0vROEry89gALwJaCzD0Q== X-Google-Smtp-Source: ABdhPJyquL7WckJN3wJmI9+MCXWVqu+klGqP6Sx4hs4lX0Hbggq7kX2kH5pnFguM1WeHen2WMjfG0ygGZMfeOWAB7SI= X-Received: by 2002:a05:6102:3e86:: with SMTP id m6mr8887134vsv.77.1641416981874; Wed, 05 Jan 2022 13:09:41 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 5 Jan 2022 14:09:31 -0700 Message-ID: Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES To: Ed Maste Cc: Mateusz Guzik , Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="000000000000221b4005d4dc2c64" X-Rspamd-Queue-Id: 4JThvB48bKz52wZ X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20210112.gappssmtp.com header.s=20210112 header.b=ibQn1oTj; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::932) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-0.74 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.74)[-0.736]; RCVD_COUNT_TWO(0.00)[2]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20210112.gappssmtp.com:s=20210112]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20210112.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::932:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org] X-ThisMailContainsUnwantedMimeParts: N --000000000000221b4005d4dc2c64 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022 at 2:06 PM Ed Maste wrote: > On Wed, 5 Jan 2022 at 15:47, Warner Losh wrote: > > > > NOIP kernels were already broken when I made this commit. I'll take a > look now that emaste committed fixes for those... > > I think w/o INET should have built as of my a6668e31aa3c commit. > > I also tried building without both INET and INET6. A number of drivers > have checksum offload support that calls in_pseudo() (or similar) > without #ifdef guards, and in_pseduo isn't available in that case. > After hacking those cases I was able to build without INET and INET6. > > Affected drivers: age alc ale bxe fxp jme msk sge sk > Yea, a6668e31aa3c was after my adding lio back. But I'll take a look. Warner --000000000000221b4005d4dc2c64 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Wed, Jan 5, 2022 at 2:06 PM Ed Mas= te <emaste@freebsd.org> wro= te:
On Wed, 5 Ja= n 2022 at 15:47, Warner Losh <imp@bsdimp.com> wrote:
>
> NOIP kernels were already broken when I made this commit. I'll tak= e a look now that emaste committed fixes for those...

I think w/o INET should have built as of my a6668e31aa3c commit.

I also tried building without both INET and INET6. A number of drivers
have checksum offload support that calls in_pseudo() (or similar)
without #ifdef guards, and in_pseduo isn't available in that case.
After hacking those cases I was able to build without INET and INET6.

Affected drivers: age alc ale bxe fxp jme msk sge sk
<= br>
Yea,=C2=A0a6668e31aa3c was after my adding lio back. But I= 9;ll take a look.

Warner
--000000000000221b4005d4dc2c64--