From nobody Wed Jan 05 20:53:40 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 742E31945316; Wed, 5 Jan 2022 20:53:48 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JThXr2clzz4yDf; Wed, 5 Jan 2022 20:53:48 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-oi1-x229.google.com with SMTP id r131so791307oig.1; Wed, 05 Jan 2022 12:53:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=R1D9T8Nh+N3jWzLmTAIL21iC6kpJ3uTpD3ehSk6IQt0=; b=HGqhNFjWVASyqgj/e4sKjCcRf7oN/AICTBT3VSUiQqss2GCwBXu3CpCAvKI6+iXdCE d604eao/Keenvj8Rx3kYmZGFcRmDs3KZb1lQDLLmLGK2aAvJMct0A0YVXc/5+JaYEul+ nCpf+uwc3keYnLWa0VjhbowI3RkLAy8pFoE4nCm8RvwfSl9xQL7YBBHgygKn3XPFoTHY RZR8+JlUMMRB/yv4YUrKz9ZdAh6J0FDUuu735PwDXhSW3WNuXdGxziCV138OTTatXLi2 mGroUIarcSf6+yel2+vePwdvvPmwzqQ5sPAKbgp70h+Udtgx2azoScTid55p5gOqsKpg PaDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=R1D9T8Nh+N3jWzLmTAIL21iC6kpJ3uTpD3ehSk6IQt0=; b=DlVovRbqwbj5nwiPSJHg8SxCCg97cAeR2pCrCZrF8eHZoUbPfg3Bklk/uZxL3Nhl15 oJLTYL/dG4cDP0ht+ZIf2Vh315xYP9akKZWpAU6JIFePKD4yFyZInwcYW7XNIMPjuam3 rwE4KdodZIj8e+9vN6/dQW2wEZrr4hSjW+AlEPX9G2v5zGP9jitRxlergORKvunCu7Cd FjpH9HPbKwoQ2wyeQWcCjrJ8FUmifHOyXlvZKQg97MtQU1Ftxqh8qJax3wChBC8nqSTp 8SKvSDNW1YCShdvAVTWpWIgNrGsWdF35XKB0oymfImUe03EX+oPd1B817uQC/CE2eLa3 e9Ww== X-Gm-Message-State: AOAM533Pg/X6qe9HVNKTrn7ZjCgzEn/8QXz+XqH0kil03YfSkWHWW7t9 8gweUr3g9jNXyANdinx0qQEp4+E/SMX/+ioqj7TTb+k8 X-Google-Smtp-Source: ABdhPJwVb0CYLepqS6xVzBipbZWoj+noFnvJjKwb741OJU0iY2P9vGbufA4WoMUYR9L6oqvc6natsso0Z/VTKuE29dU= X-Received: by 2002:a05:6808:7:: with SMTP id u7mr3862830oic.75.1641416021188; Wed, 05 Jan 2022 12:53:41 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Received: by 2002:ac9:7f0a:0:b0:3f5:9e34:628e with HTTP; Wed, 5 Jan 2022 12:53:40 -0800 (PST) In-Reply-To: References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> From: Mateusz Guzik Date: Wed, 5 Jan 2022 21:53:40 +0100 Message-ID: Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES To: Warner Losh Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4JThXr2clzz4yDf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 1/5/22, Warner Losh wrote: > On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik wrote: > >> On 12/31/21, Warner Losh wrote: >> > The branch main has been updated by imp: >> > >> > URL: >> > >> https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4 >> > >> > commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4 >> > Author: Warner Losh >> > AuthorDate: 2021-12-31 21:56:16 +0000 >> > Commit: Warner Losh >> > CommitDate: 2021-12-31 21:56:16 +0000 >> > >> > Add lio back to NOTES >> > >> > lio appears to be partially removed from this file. It's a modern >> > enough >> > card, so add it back. It builds everywhere. >> > >> >> This breaks NOIP kernels: >> > > NOIP kernels were already broken when I made this commit. I'll take a look > now that emaste committed fixes for those... > It builds fine without the change. > Warner > > ld: error: undefined symbol: tcp_lro_flush_all >> >>> referenced by lio_droq.c >> >>> lio_droq.o:(lio_droq_process_packets) >> >> ld: error: undefined symbol: tcp_lro_rx >> >>> referenced by lio_core.c >> >>> lio_core.o:(lio_push_packet) >> >> ld: error: undefined symbol: tcp_lro_init >> >>> referenced by lio_main.c >> >>> lio_main.o:(lio_attach) >> >> ld: error: undefined symbol: tcp_lro_free >> >>> referenced by lio_main.c >> >>> lio_main.o:(lio_attach) >> >>> referenced by lio_main.c >> >>> lio_main.o:(lio_destroy_nic_device) >> >> > Sponsored by: Netflix >> > --- >> > sys/conf/NOTES | 1 + >> > 1 file changed, 1 insertion(+) >> > >> > diff --git a/sys/conf/NOTES b/sys/conf/NOTES >> > index 65e088cfe7c9..eded586b4491 100644 >> > --- a/sys/conf/NOTES >> > +++ b/sys/conf/NOTES >> > @@ -1931,6 +1931,7 @@ envvar hint.fxp.0.prefer_iomap="0" >> > device gem # Apple GMAC/Sun ERI/Sun GEM >> > device jme # JMicron JMC250 Gigabit/JMC260 >> Fast Ethernet >> > device lge # Level 1 LXT1001 gigabit >> > Ethernet >> > +device lio # Support for Cavium 23XX >> > Ethernet >> adapters >> > device mlxfw # Mellanox firmware update module >> > device mlx5 # Shared code module between IB >> and Ethernet >> > device mlx5en # Mellanox ConnectX-4 and >> ConnectX-4 LX >> > >> >> >> -- >> Mateusz Guzik >> > -- Mateusz Guzik