From nobody Wed Jan 05 20:47:44 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id B513819427DD for ; Wed, 5 Jan 2022 20:48:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JThQB3V18z4vSB for ; Wed, 5 Jan 2022 20:48:02 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x934.google.com with SMTP id o63so684383uao.5 for ; Wed, 05 Jan 2022 12:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g1q1sCbyaWtcs91j1yLxTZcOdhLt2EMopnKkGGhm3dQ=; b=yygYJ1UtCgS9toA6d4TCyrXbYY1t0EytYgY/D/5jAXJAD2qQpVaYPLB4ctLBZSpiEd HhH3a8WlqOz9FGnk2cYbRv8oR5Nq3GHhVk2L8c6k/niHDGfvq34V1fvSfPDir+ytwLn/ U81HOEQXjFR58RRAOeaDF5ZOOfi+52My474cb4AEaiJgNPXvk7UdfJ4zNn9cS0to8quk arCBWyh5whjw5CT7ZquaMzyiRvAEwimC9kI3bxXgmIsxxon7l1PQD7qFMPoREWA0dsl1 9CfBO80LHtU1zhm1twGKB1lok6MgfuWeNZXV0OlPm8izer8ucBVjIFKQ1eHCwAdfGcW7 ZYgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g1q1sCbyaWtcs91j1yLxTZcOdhLt2EMopnKkGGhm3dQ=; b=Ien3LP69dHC7/+4yLGZziQnN+VIjl8kh8XEieh9Ws7lGGQmp7ZlCMqBVudivrUQyCl fnEWqVF+IlcP9TdEXZCoufyLGnzPpme6GRB3fTa+JgW7H5rfR4Vp43vjd96aPm4DS6nk r9aIgwWtIiAXBcWG0saG8ezODTTgdl3JfDAweXnkP9p3vZb4JiuAbS28wvf54F91vsgr JpwF/ebl+lun/wY+6rf6QZoOmobSRrZ7gblL42d6okqUg/yzqNrtht8wjjNyxjBrfjNJ zKTdG4O+nHuxosMOITcFq1toJchNIUoOmjxpSYXUhwISUD031IMBaCW9aGyx/R3bn5ro 9LwQ== X-Gm-Message-State: AOAM5334wfyJ1gMwuhX7F09+Mzj3qnFT5mPbRbWwj4pEfHIs1BU6+cPf zjrEJbPTALBr2QJcCWxhrqDtzYL5TOQShtbkXkI+uA== X-Google-Smtp-Source: ABdhPJyQyAG4Dv9GmLjeh3KWIIcey2DgCKh/XVitPDdMsevaNA/nVlZAvZOrXW4xRJ2ZZSZZyEBlpDPwBD+Htu9CQak= X-Received: by 2002:a05:6102:3e86:: with SMTP id m6mr8851613vsv.77.1641415675802; Wed, 05 Jan 2022 12:47:55 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202112312157.1BVLvLhd040939@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Wed, 5 Jan 2022 13:47:44 -0700 Message-ID: Subject: Re: git: 5a73a6c178f6 - main - Add lio back to NOTES To: Mateusz Guzik Cc: Warner Losh , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000049151a05d4dbdeba" X-Rspamd-Queue-Id: 4JThQB3V18z4vSB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --00000000000049151a05d4dbdeba Content-Type: text/plain; charset="UTF-8" On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik wrote: > On 12/31/21, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > > > https://cgit.FreeBSD.org/src/commit/?id=5a73a6c178f65b91fe60e52e476a88137e40f0e4 > > > > commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4 > > Author: Warner Losh > > AuthorDate: 2021-12-31 21:56:16 +0000 > > Commit: Warner Losh > > CommitDate: 2021-12-31 21:56:16 +0000 > > > > Add lio back to NOTES > > > > lio appears to be partially removed from this file. It's a modern > > enough > > card, so add it back. It builds everywhere. > > > > This breaks NOIP kernels: > NOIP kernels were already broken when I made this commit. I'll take a look now that emaste committed fixes for those... Warner ld: error: undefined symbol: tcp_lro_flush_all > >>> referenced by lio_droq.c > >>> lio_droq.o:(lio_droq_process_packets) > > ld: error: undefined symbol: tcp_lro_rx > >>> referenced by lio_core.c > >>> lio_core.o:(lio_push_packet) > > ld: error: undefined symbol: tcp_lro_init > >>> referenced by lio_main.c > >>> lio_main.o:(lio_attach) > > ld: error: undefined symbol: tcp_lro_free > >>> referenced by lio_main.c > >>> lio_main.o:(lio_attach) > >>> referenced by lio_main.c > >>> lio_main.o:(lio_destroy_nic_device) > > > Sponsored by: Netflix > > --- > > sys/conf/NOTES | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sys/conf/NOTES b/sys/conf/NOTES > > index 65e088cfe7c9..eded586b4491 100644 > > --- a/sys/conf/NOTES > > +++ b/sys/conf/NOTES > > @@ -1931,6 +1931,7 @@ envvar hint.fxp.0.prefer_iomap="0" > > device gem # Apple GMAC/Sun ERI/Sun GEM > > device jme # JMicron JMC250 Gigabit/JMC260 > Fast Ethernet > > device lge # Level 1 LXT1001 gigabit Ethernet > > +device lio # Support for Cavium 23XX Ethernet > adapters > > device mlxfw # Mellanox firmware update module > > device mlx5 # Shared code module between IB > and Ethernet > > device mlx5en # Mellanox ConnectX-4 and > ConnectX-4 LX > > > > > -- > Mateusz Guzik > --00000000000049151a05d4dbdeba Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Wed, Jan 5, 2022, 1:26 PM Mateusz Guzik <mjguzik@gmail.com> wrote:
On 12/31/21, Warner Losh <imp@freebsd.org&g= t; wrote:
> The branch main has been updated by imp:
>
> URL:
> ht= tps://cgit.FreeBSD.org/src/commit/?id=3D5a73a6c178f65b91fe60e52e476a88137e4= 0f0e4
>
> commit 5a73a6c178f65b91fe60e52e476a88137e40f0e4
> Author:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> AuthorDate: 2021-12-31 21:56:16 +0000
> Commit:=C2=A0 =C2=A0 =C2=A0Warner Losh <imp@FreeBSD.org>
> CommitDate: 2021-12-31 21:56:16 +0000
>
>=C2=A0 =C2=A0 =C2=A0Add lio back to NOTES
>
>=C2=A0 =C2=A0 =C2=A0lio appears to be partially removed from this file.= It's a modern
> enough
>=C2=A0 =C2=A0 =C2=A0card, so add it back. It builds everywhere.
>

This breaks NOIP kernels:
NOIP kernels were already broken when I made this = commit. I'll take a look now that emaste committed fixes for those...

Warner=C2=A0

ld: error: undefined symbol: tcp_lro_flush_all
>>> referenced by lio_droq.c
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio_droq= .o:(lio_droq_process_packets)

ld: error: undefined symbol: tcp_lro_rx
>>> referenced by lio_core.c
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio_core= .o:(lio_push_packet)

ld: error: undefined symbol: tcp_lro_init
>>> referenced by lio_main.c
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio_main= .o:(lio_attach)

ld: error: undefined symbol: tcp_lro_free
>>> referenced by lio_main.c
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio_main= .o:(lio_attach)
>>> referenced by lio_main.c
>>>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio_main= .o:(lio_destroy_nic_device)

>=C2=A0 =C2=A0 =C2=A0Sponsored by:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0Netflix
> ---
>=C2=A0 sys/conf/NOTES | 1 +
>=C2=A0 1 file changed, 1 insertion(+)
>
> diff --git a/sys/conf/NOTES b/sys/conf/NOTES
> index 65e088cfe7c9..eded586b4491 100644
> --- a/sys/conf/NOTES
> +++ b/sys/conf/NOTES
> @@ -1931,6 +1931,7 @@ envvar=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 hint.fx= p.0.prefer_iomap=3D"0"
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gem= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# Apple GMAC/Sun ERI/Sun GE= M
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0jme= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# JMicron JMC250 Gigabit/JM= C260 Fast Ethernet
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lge= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# Level 1 LXT1001 gigabit E= thernet
> +device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lio=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# Support for Cavium 23XX Ethe= rnet adapters
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mlx= fw=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0# Mellanox firmware update modul= e
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mlx= 5=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # Shared code module between IB = and Ethernet
>=C2=A0 device=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0mlx= 5en=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 # Mellanox ConnectX-4 and ConnectX-4 = LX
>


--
Mateusz Guzik <mjguzik gmail.com>
--00000000000049151a05d4dbdeba--