From nobody Wed Jan 05 16:41:32 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 1D769193E11C; Wed, 5 Jan 2022 16:41:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JTZxm4cCwz4ry9; Wed, 5 Jan 2022 16:41:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 79C4677D5; Wed, 5 Jan 2022 16:41:32 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 205GfWGc041758; Wed, 5 Jan 2022 16:41:32 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 205GfWZV041757; Wed, 5 Jan 2022 16:41:32 GMT (envelope-from git) Date: Wed, 5 Jan 2022 16:41:32 GMT Message-Id: <202201051641.205GfWZV041757@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alexander Motin Subject: git: 9e007a88d65b - main - atkbd: Reduce polling rate from 10Hz to ~1Hz. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mav X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9e007a88d65ba0d23e73c3c052d474a78260d503 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641400892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F5asDxIJZ5tf9CYNg/ahHbR8Cu8DEcUWPyGSPuiG37Y=; b=xHTEHZIGVMWZfpBKHpmbnbYBGPBZ8iMsNnEHvhpBgHS7O14vq2s4C1J5Eal9j5XSs8Ywam jI3GAVgUJM6T6/N6dy7ZMet666IHnfzL2b9uzqy7vLG6NTMXCS2ebL1RfAI6J856Rdu7RM cO41E4eNbrTLM6UJDRK/eNJH2YXttAQRaOHLJKZQLwBM2nlCOKHo6B+UXxlH8hMUPlbN8I qbZviGGF4B18CzvMJgRC9/AREE7SbKm7KCENgrlEFv/pPDc9EZfbChohhN5YX1td3RZAXt Z8z+s4gax2h9BBvDySpYBWnzRc3TCWvpheldbtgkSN34dz6uMRkDn45w5DOdcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641400892; a=rsa-sha256; cv=none; b=Wedaz7T6e82ptcQJYeKigs+Ga7KPESOYbyCYvWN9sdbDngouVZ5hJn0Dvp0hfaR1pJ0hYM x2Derk6RuZBu6iotBdwoSzX5sO6GBQmQWIStsa1ilR2dYpSQhPmsvZj10tsskyCcP2qdZL JESgvJOz82AfhVdk8ysdZLaxtJPAHEyiPKIhUm+UlXEX2UEqNOhp7JrApqqxmW3XSKS6Pe oq3vQuPjgqtq9sjWVoLZy3b61+II/ZkMPziNF3FVlM9QDEwOlBNUtjiWVKJmVbNRo0oSBV 2oxIfmiTaX4HC2+LilkaJCE1leDUg76W2jCwWw3hhzR8B4PcLnSylCWQD0q9zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=9e007a88d65ba0d23e73c3c052d474a78260d503 commit 9e007a88d65ba0d23e73c3c052d474a78260d503 Author: Alexander Motin AuthorDate: 2022-01-05 16:32:44 +0000 Commit: Alexander Motin CommitDate: 2022-01-05 16:41:26 +0000 atkbd: Reduce polling rate from 10Hz to ~1Hz. In my understanding this is only needed to workaround lost interrupts. I was thinking to remove it completely, but the comment about edge- triggered interrupt may be true and needs deeper investigation. ~1Hz should be often enough to handle the supposedly rare loss cases, but rare enough to not appear in top. Add sysctl hw.atkbd.hz to tune it. MFC after: 1 month --- sys/dev/atkbdc/atkbd.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/sys/dev/atkbdc/atkbd.c b/sys/dev/atkbdc/atkbd.c index 40dd698984e3..cee1207df973 100644 --- a/sys/dev/atkbdc/atkbd.c +++ b/sys/dev/atkbdc/atkbd.c @@ -42,6 +42,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include #include @@ -73,6 +74,13 @@ typedef struct atkbd_state { #endif } atkbd_state_t; +static SYSCTL_NODE(_hw, OID_AUTO, atkbd, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, + "AT keyboard"); + +static int atkbdhz = 1; +SYSCTL_INT(_hw_atkbd, OID_AUTO, hz, CTLFLAG_RWTUN, &atkbdhz, 0, + "Polling frequency (in hz)"); + static void atkbd_timeout(void *arg); static int atkbd_reset(KBDC kbdc, int flags, int c); @@ -198,8 +206,11 @@ atkbd_timeout(void *arg) kbdd_intr(kbd, NULL); } splx(s); - state = (atkbd_state_t *)kbd->kb_data; - callout_reset(&state->ks_timer, hz / 10, atkbd_timeout, arg); + if (atkbdhz > 0) { + state = (atkbd_state_t *)kbd->kb_data; + callout_reset_sbt(&state->ks_timer, SBT_1S / atkbdhz, 0, + atkbd_timeout, arg, C_PREL(1)); + } } /* LOW-LEVEL */