From nobody Tue Jan 04 14:48:00 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7AA34192CF4E; Tue, 4 Jan 2022 14:48:01 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JSwTD4JHzz3hWK; Tue, 4 Jan 2022 14:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6BC741AF15; Tue, 4 Jan 2022 14:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 204Em0IB057205; Tue, 4 Jan 2022 14:48:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 204Em04B057204; Tue, 4 Jan 2022 14:48:00 GMT (envelope-from git) Date: Tue, 4 Jan 2022 14:48:00 GMT Message-Id: <202201041448.204Em04B057204@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: ed166a017324 - main - mvneta: Unconditionally print an error message if mii_attach() fails List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ed166a0173247e267c507ebd0ec03cb04aaf49ee Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1641307680; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ssrQoEd7q8l63wylRXL+hIv61RBg5QKeOwF6i/2IKbM=; b=a7HJz/WRNzGMvk7/JNl0E0FR9f5hgH9QUarlHDdzVbA0jkNfHhnVTPj+7OK9sCgQoALXdA a0q7UQEBfs/RAVon8xVPu8DxsKoIvNlgr2byviDnTn8SeewQqGFMFglaUHJSk4qMoELPet jLqvo6Xn6sI5EXp4zFXx6Q2BlTVuIywZFFKHtWFrSmokmP8rvhtHsDIHQOqX8CseUjcyLw HcIgRfE6sDxyJY9XjKaFcwlYXM7N5Ji+x2yLkzFy1s+xrPVP277fwmy5ejBPf1z9JX9aFF /M7DC5F/4MEyWdUJlUi32z+Rnpqy4RqZbk3MEP7JvtbuYP4np96w6jQniJp7MQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1641307680; a=rsa-sha256; cv=none; b=x0OhDA++jVSOZbxROk1y34TOq0nV/PBH+9Z5CrfN1ZBFDMrZM1yT1N9TZfQJgOuzD+VJZN ZyYR45BGyeba2ZPW2TrPiegaIQezMbc6GJr7oUMCIAieoXEffqeE7nAEIjdFgekgbegYIP NkYrdKLip8PKPfAwtGQ5XuhiKqffUlG/lSPIfHi7/GG0BnsdKWvprxsou3S7yFUd+Uw+5p 6IdXMaxWz/7UWDrVdO9pUr3bbvbv8y49gsGtk6wwl+cdsvOUW/h2SpfBg5pxlImOvDi+tX XltVdpv8yHF4whKy7R2ZQJheStzVdVKzcPmf7bxwXE+aWBCvRisuoJ3HuWdU0g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=ed166a0173247e267c507ebd0ec03cb04aaf49ee commit ed166a0173247e267c507ebd0ec03cb04aaf49ee Author: Mark Johnston AuthorDate: 2022-01-04 14:42:34 +0000 Commit: Mark Johnston CommitDate: 2022-01-04 14:46:23 +0000 mvneta: Unconditionally print an error message if mii_attach() fails The error message is useful for diagnosing mvneta_attach() failures. MFC after: 1 week --- sys/dev/neta/if_mvneta.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sys/dev/neta/if_mvneta.c b/sys/dev/neta/if_mvneta.c index 4d54e95e807d..0ea86330877b 100644 --- a/sys/dev/neta/if_mvneta.c +++ b/sys/dev/neta/if_mvneta.c @@ -724,10 +724,8 @@ mvneta_attach(device_t self) mvneta_mediastatus, BMSR_DEFCAPMASK, sc->phy_addr, MII_OFFSET_ANY, 0); if (error != 0) { - if (bootverbose) { - device_printf(self, - "MII attach failed, error: %d\n", error); - } + device_printf(self, "MII attach failed, error: %d\n", + error); ether_ifdetach(sc->ifp); mvneta_detach(self); return (error);