Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled
Date: Sun, 02 Jan 2022 18:27:09 UTC
> On 2. Jan 2022, at 18:22, Jessica Clarke <jrtc27@freebsd.org> wrote:
>
> On 2 Jan 2022, at 17:17, Gleb Smirnoff <glebius@freebsd.org> wrote:
>>
>> On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote:
>> E> The branch main has been updated by emaste:
>> E>
>> E> URL: https://cgit.FreeBSD.org/src/commit/?id=daf481f3d508e7497b456e8df7db17c90b623ee0
>> E>
>> E> commit daf481f3d508e7497b456e8df7db17c90b623ee0
>> E> Author: Ed Maste <emaste@FreeBSD.org>
>> E> AuthorDate: 2021-12-31 01:11:31 +0000
>> E> Commit: Ed Maste <emaste@FreeBSD.org>
>> E> CommitDate: 2021-12-31 18:16:30 +0000
>> E>
>> E> rescue: include ping iff at least one of INET & INET6 is enabled
>> E>
>> E> Ping does not build (and serves no purpose) if neither is enabled
>> E> (i.e., building WITHOUT_INET and WITHOUT_INET6).
>> E>
>> E> This is equvalent to a4ef9e58bc0c but for rescue/.
>> E>
>> E> PR: 260082
>> E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one of...")
>> E> Sponsored by: The FreeBSD Foundation
>>
>> Shouldn't be ping built only with INET and ping6 with INET6?
>> Is there any use of ping on machine that doesn't have IPv4?
>
> ping does both these days:
>
> commit 0b1064b00fa3ed9c6ac31e2af1fc56c528d7b47d
> Author: asomers <asomers@FreeBSD.org>
> Date: Thu Nov 26 04:29:30 2020 +0000
>
> Merge ping6 to ping
>
> There is now a single ping binary, which chooses to use ICMP or ICMPv4
> based on the -4 and -6 options, and the format of the address.
>
> Submitted by: Ján Sučan <sucanjan@gmail.com>
> Sponsored by: Google LLC (Google Summer of Code 2019)
> MFC after: Never
> Differential Revision: https://reviews.freebsd.org/D21377
What I find surprising is that using now
ping some-host-which-is-ipv6-capable
uses IPv6 instead of IPv4. So if you want the functionality of the old ping, you have to use
ping -4 now...
Best regards
Michael
>
> Jess
>