From nobody Sun Jan 02 17:22:39 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 7B62919294BA for ; Sun, 2 Jan 2022 17:22:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JRm0m2c2lz3p6l for ; Sun, 2 Jan 2022 17:22:48 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f54.google.com with SMTP id d9so65855965wrb.0 for ; Sun, 02 Jan 2022 09:22:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=n+jLT0BV2ZYpLnMxlSXpuXP9R1F3L7SQyEpcTBpeDXU=; b=S2jJopK8eB2AP1qTGKGqYSOcbJmdL9yV052f0se80nvd72LAKYtZUh7WLwuakCv9Qu pJaJWEx7ZFdz/dTcBtAp3YuRPVBKlqS7Wos4eDqhx7Fy6y5JrqoqoznefFGBatGLqZO4 vlgJoOR0P7YBsDF2PgwOyDwM3uOGM29UDyyBucjrfqBND0nheooW2Josqir7J0l/UaRf x9TjYPKucUkWQmNUuLwXrP60LURJ6vhnD+WmJdhPGp2KV/4X/9wI5KI402Kj8nZT7LJy La5G1mPJG9etMg+UkC8paO5LyVuzk6WLyAbp7U2BRyxZy9W6dxPsbtl5+uQzYl9HXdje 3nJA== X-Gm-Message-State: AOAM5327uu4BidieiC/lSxw9HMPgg5pjdJLP4NrWCozBRaEzeWqrMeG2 FDow88g5K/XqMRLPitLhRFcWIA== X-Google-Smtp-Source: ABdhPJxbGdbmibc68KIuLkMkFNxpfHkT4oZEMZ+F1yDKK0v+5n2xIUFfyB3xlAK3vPfIYGXKESTlrA== X-Received: by 2002:a5d:5604:: with SMTP id l4mr2655242wrv.414.1641144160982; Sun, 02 Jan 2022 09:22:40 -0800 (PST) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id o15sm26217336wri.106.2022.01.02.09.22.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jan 2022 09:22:40 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: daf481f3d508 - main - rescue: include ping iff at least one of INET & INET6 is enabled From: Jessica Clarke In-Reply-To: Date: Sun, 2 Jan 2022 17:22:39 +0000 Cc: Ed Maste , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <50E91562-8850-43CD-AF44-34A96085EF41@freebsd.org> References: <202112311818.1BVIIr2P048142@gitrepo.freebsd.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4JRm0m2c2lz3p6l X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 2 Jan 2022, at 17:17, Gleb Smirnoff wrote: >=20 > On Fri, Dec 31, 2021 at 06:18:53PM +0000, Ed Maste wrote: > E> The branch main has been updated by emaste: > E>=20 > E> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Ddaf481f3d508e7497b456e8df7db17c9= 0b623ee0 > E>=20 > E> commit daf481f3d508e7497b456e8df7db17c90b623ee0 > E> Author: Ed Maste > E> AuthorDate: 2021-12-31 01:11:31 +0000 > E> Commit: Ed Maste > E> CommitDate: 2021-12-31 18:16:30 +0000 > E>=20 > E> rescue: include ping iff at least one of INET & INET6 is = enabled > E> =20 > E> Ping does not build (and serves no purpose) if neither is = enabled > E> (i.e., building WITHOUT_INET and WITHOUT_INET6). > E> =20 > E> This is equvalent to a4ef9e58bc0c but for rescue/. > E> =20 > E> PR: 260082 > E> Fixes: a4ef9e58bc0c ("sbin: build ping if at least one = of...") > E> Sponsored by: The FreeBSD Foundation >=20 > Shouldn't be ping built only with INET and ping6 with INET6? > Is there any use of ping on machine that doesn't have IPv4? ping does both these days: commit 0b1064b00fa3ed9c6ac31e2af1fc56c528d7b47d Author: asomers Date: Thu Nov 26 04:29:30 2020 +0000 Merge ping6 to ping =20 There is now a single ping binary, which chooses to use ICMP or = ICMPv4 based on the -4 and -6 options, and the format of the address. =20 Submitted by: J=C3=A1n Su=C4=8Dan Sponsored by: Google LLC (Google Summer of Code 2019) MFC after: Never Differential Revision: https://reviews.freebsd.org/D21377 Jess