From nobody Mon Feb 28 16:41:55 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ACF4119E2B42; Mon, 28 Feb 2022 16:42:13 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4K6mPd4T8Qz3Mq4; Mon, 28 Feb 2022 16:42:13 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f169.google.com with SMTP id z7so13717893oid.4; Mon, 28 Feb 2022 08:42:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UVhrioh2+lMkpAhbK82MlDp+inZC3BX6lag3aGa+xXw=; b=FEYCQJ9hjwweQu7IR6CfW0J9K7Zw6QC5LitnS8AoRTqePo7L7MoDHnKs1WiD2EIY5b HXiVIapHzxR/BLQFCGmhnW4hOQqgkKf7olOEJT2GGd8tHtzHfGh/0AqsI/5bCy0evj1M VDKHbqYl6aOX0k+kI6K//a1U0fBYFlzWXx8esBpvUaizpcw79v9pwg5M+61MNVIKJvgK m66WX0ZXUaC5BAq0ZJYiMLnpwGqEEYSkanWOuTT3Ctk22UZ1Q111vGJCp5pSRONYgA+k lbtVrTFUwsLLISNYkQ0Bi6ir7naCvB+aioku6jxN5Cn0ByEEscCKRGucbygSZWuDV3LS swaQ== X-Gm-Message-State: AOAM533PqvzgbKvxwyxG/qxgqOWVbevHmevlfoj48h3G3sqPeDITQUsX wNgtWbW0zgNrvxabrA7hj4NBBGdSuI7CpKKAZNJnP4KI X-Google-Smtp-Source: ABdhPJyRFIQpWJy0RYm03gwrO4F4VJoR1bVhhcrnBDohWD6085mUa9L6e1jpWav4G5YYdHVfCMrdGm0d2RmF+rkvYuU= X-Received: by 2002:a05:6808:211a:b0:2d7:940f:3ee1 with SMTP id r26-20020a056808211a00b002d7940f3ee1mr3922522oiw.57.1646066526483; Mon, 28 Feb 2022 08:42:06 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202202280416.21S4G8D0064972@gitrepo.freebsd.org> In-Reply-To: From: Alan Somers Date: Mon, 28 Feb 2022 09:41:55 -0700 Message-ID: Subject: Re: git: c068632981eb - main - Add ggated rc script To: Mateusz Piotrowski <0mp@freebsd.org> Cc: src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4K6mPd4T8Qz3Mq4 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On Mon, Feb 28, 2022 at 3:11 AM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > On 28/02/2022 05:16, Alan Somers wrote: > > The branch main has been updated by asomers: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=c068632981ebb7521859e3d2c0ec300a271f9b7e > > > > commit c068632981ebb7521859e3d2c0ec300a271f9b7e > > Author: Alan Somers > > AuthorDate: 2022-02-28 04:14:52 +0000 > > Commit: Alan Somers > > CommitDate: 2022-02-28 04:14:52 +0000 > > > > Add ggated rc script > > > > Reviewed by: asomers, peterj > > Submitted by: Johannes Totz > > Differential Revision: https://reviews.freebsd.org/D31709 > > --- > > libexec/rc/rc.conf | 3 +++ > > libexec/rc/rc.d/Makefile | 1 + > > libexec/rc/rc.d/ggated | 21 +++++++++++++++++++++ > > 3 files changed, 25 insertions(+) > > > > diff --git a/libexec/rc/rc.conf b/libexec/rc/rc.conf > > index 1812b099530a..23a397c3b4ad 100644 > > --- a/libexec/rc/rc.conf > > +++ b/libexec/rc/rc.conf > > @@ -296,6 +296,9 @@ iscsictl_flags="-Aa" # Optional flags to iscsictl. > > hastd_enable="NO" # Run the HAST daemon (YES/NO). > > hastd_program="/sbin/hastd" # path to hastd, if you want a different one. > > hastd_flags="" # Optional flags to hastd. > > +ggated_enable="NO" # Run the ggate daemon (YES/NO). > > +ggated_config="/etc/gg.exports" > > +ggated_params="" # Extra parameters like which port to bind to. > Shouldn't _params be _flags instead? > > diff --git a/libexec/rc/rc.d/ggated b/libexec/rc/rc.d/ggated > > new file mode 100644 > > index 000000000000..dc31468920ef > > --- /dev/null > > +++ b/libexec/rc/rc.d/ggated > > @@ -0,0 +1,21 @@ > > +#!/bin/sh > > + > > +# PROVIDE: ggated > > +# REQUIRE: NETWORKING > > + > > +. /etc/rc.subr > > + > > +name="ggated" > > +desc="GEOM Gate network daemon" > > +rcvar="ggated_enable" > > +command="/sbin/${name}" > > +pidfile="/var/run/${name}.pid" > > + > > +load_rc_config $name > > +params="${ggated_params}" > > +config="${ggated_config:-/etc/gg.exports}" > Is it necessary to set the default here again if it is already set in /etc/defaults/rc.conf? > > > Best, > > Mateusz You're right, I don't think it's necessary. Do you want me to remove it?