From nobody Wed Feb 16 20:25:57 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CCA4519BC30F; Wed, 16 Feb 2022 20:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JzTxK5517z3LSG; Wed, 16 Feb 2022 20:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645043157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rd5DkYuQY47KWmQB4Snj8QjYiHCOfEoojPAgTPiIQVE=; b=L9ENuQ7Vmw8KbHVgpVvYVNemdQB9OuDS5WSk6EIMsBEb9SYqVUteyew6OUZqizcjtCJcMI uMdYzqwMv0pXMutJytbIhkQGlOIR3P0SWBg+3EmJEbJi1tKJe+OMOcG7az9K/kG69eHJtP uX+DYDVromnfPRebpi9Nz7G4q6YNXguYpBczKKte3cMO5KpsiOLfrnk8WX3Trins60HWwO d+V8AF24II+HoK6PLLKHC3YAgWf277m7NTZ42xZFIwIBIF0UcxhWigMQJwJzuW3Ao1WLeX InUJ0BW9IrjLV40bCbqoECPdNyjyzbIISSDjAbfsUB/i/Q9Bo6z8mvnH6xQ3Eg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8FB9F1CD0B; Wed, 16 Feb 2022 20:25:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21GKPvKc051362; Wed, 16 Feb 2022 20:25:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21GKPvt4051361; Wed, 16 Feb 2022 20:25:57 GMT (envelope-from git) Date: Wed, 16 Feb 2022 20:25:57 GMT Message-Id: <202202162025.21GKPvt4051361@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Dimitry Andric Subject: git: be8e341777c0 - stable/13 - bwi: Fix clang 14 warning about possible unaligned access List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dim X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: be8e341777c0e560c4db1cfb576f75ab8a041c31 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1645043157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Rd5DkYuQY47KWmQB4Snj8QjYiHCOfEoojPAgTPiIQVE=; b=birbiekhIDAZ3eQeCWU2FXGoNQEDt9NSBRSXdPjXfuEQUv6bEf5wSE0q+Flb5cpzNwHbbf d1mwCprvl3jcECte42Er0ClIAq00HtiD/jy7F9q78muv7XFW5w82ij76mugTEy5lkZ9LaZ /Lr4exwbaFP2zstskcZcI4Yg23b5cHYpflV+mKaGRPxX9doNxwQ9e5PcrLdL0axx4NKPqV cVeQ4xuUhTv+xQ/P8St+b7rkou8iCAQ4+VpPGh+RZnuBXQos5M4YY6O+a3bkg98OYUVycK 3Kfw/FbCWbDtDKAMwyR5O3jHJ4baA5JmYk6wqa8EoOr4InIpU3ieOwQED5X4jg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1645043157; a=rsa-sha256; cv=none; b=c97LRpQYVHUtiQI09nFARvKKt6PMn342lEIanH+PgslW9p8Yh0vn2wS7fVLgNqypn9vVqG DvbEqVrtA/XBDqR+KTRA+sBBvVN9J9uzJvGUMEGu5ybDu9N1hV0CV7x/pylLXfpZPmyoc9 3IFQPdqdt8EFaGEw11YCPYBwCxxV4xP0yfKvCI2pwF8tbfRaNNkiA05hXATWS6K78UOzhz cwl9qzJphDA7XS/B9V9SKjpKWVa2baopRmNKhLE43U3qoxM27AKsRNDGlEwiBch1hXkFkw nT32vSLqcp9wbmb8rPK4hsCsKdKjxwo2nCSjKdFuSJ4yNh5rFd3dpzYFcNTelQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch stable/13 has been updated by dim: URL: https://cgit.FreeBSD.org/src/commit/?id=be8e341777c0e560c4db1cfb576f75ab8a041c31 commit be8e341777c0e560c4db1cfb576f75ab8a041c31 Author: Dimitry Andric AuthorDate: 2022-02-07 20:59:46 +0000 Commit: Dimitry Andric CommitDate: 2022-02-16 20:24:53 +0000 bwi: Fix clang 14 warning about possible unaligned access On architectures with strict alignment requirements (e.g. arm), clang 14 warns about a packed struct which encloses a non-packed union: In file included from sys/dev/bwi/bwimac.c:79: sys/dev/bwi/if_bwivar.h:308:7: error: field iv_val within 'struct bwi_fw_iv' is less aligned than 'union (unnamed union at sys/dev/bwi/if_bwivar.h:305:2)' and is usually due to 'struct bwi_fw_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access] } iv_val; ^ It appears to help if you also add __packed to the inner union (i.e. iv_val). No change to the layout is intended. MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D34196 (cherry picked from commit 09d0a0fbe859e3fc7bbff0cf48c389b5e55b9e00) --- sys/dev/bwi/if_bwivar.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/bwi/if_bwivar.h b/sys/dev/bwi/if_bwivar.h index 90b4aeab6d26..9961cfca9193 100644 --- a/sys/dev/bwi/if_bwivar.h +++ b/sys/dev/bwi/if_bwivar.h @@ -305,7 +305,7 @@ struct bwi_fw_iv { union { uint32_t val32; uint16_t val16; - } iv_val; + } __packed iv_val; } __packed; #define BWI_FW_IV_OFS_MASK __BITS(14, 0)