From nobody Thu Feb 10 15:34:56 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 943E819CDD60; Thu, 10 Feb 2022 15:34:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JvgmJ3XhTz3rwm; Thu, 10 Feb 2022 15:34:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644507296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MYaQszXe/rGLDlRnRPjtxzx2BS8NSsgciReVr2koNh0=; b=isW4bkGmguhVzMHdydW7EN9Jb91I93RW8KWEcjJAV9d4zMbj8FcpO/iFzgZsxOI7QmCNhH v+7fcauVKJVNuQD0n2JMkVLL9y5BpfZJcc+FE4o2UD8XjyqcUJ4fpog+EXVIMTDSlc03bX C0qakhF7eXziRsYxq8LNHWFFaOiN/jmGT/uGc1QXeAtzZpm1vLxM1707tV/RWXwHjCl50e qDlBtgzCOI+vklKQ6EXBOF1zXA0laKC1njhKpWa6hgwtrb1FuNXIjri8ciVtuaPJZRGjtD HPv6Kke9km9NINw8doMhv0ygY4e+L5nCrwuKhPet9y8tubr92fOT1BJkDNX4ow== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 54DA823213; Thu, 10 Feb 2022 15:34:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21AFYuqa098470; Thu, 10 Feb 2022 15:34:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21AFYuZq098469; Thu, 10 Feb 2022 15:34:56 GMT (envelope-from git) Date: Thu, 10 Feb 2022 15:34:56 GMT Message-Id: <202202101534.21AFYuZq098469@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Justin Hibbits Subject: git: 6db44b0158c3 - main - Fix gzip compressed core dumps on big endian architectures List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhibbits X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6db44b0158c37f2206f2c4ea7f29f5b774389e54 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644507296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MYaQszXe/rGLDlRnRPjtxzx2BS8NSsgciReVr2koNh0=; b=VLcs6hdz1F3uODtfftPcXMglL6WZt6tF3+WM2d2yZZG2gSRnd3xabFwnYI56R9Rft9h+xx qB5aI/xcKUEBLtuBIOTvho4eUtMkBiAcV3/Mqke6sHu4GBLnTiyNSWxmweavFmjA9mN+3Y We9gdLSE6YfQF8cQONML1XrVcN8qQVdnoiHHbJLG5UZMEE+iYnegMESEovb7gvnHWUoi1h /1i2Yyk+HJ6UdHB5XY1tRvCjzbdSgI2FBCBJwj5rQ6i0qfLgfILVhTkYdhnUo9cM5muV3x S8l0fUNmNEe2PLGKo1OMSBAz7SQVVb9279Ss7gBfestfiTqZkkuZy/AObjsxWQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644507296; a=rsa-sha256; cv=none; b=Gigi/++gkBrZPA6FjeZCjFLA6gWUgcaurBvRNLuItjQh6KTON4cKWoTuC64/t1R2pGIA8H +R1x0tUey1NK9fETJLB7AqridUAHGW4GOPs2dWDZkuH4fULxdheoAyNuXEOaB/hiEnZxV4 1d3FnHJd4b4eyJ3u91uYKGNc0xtIZDC5JG5xV33NInSxEiG84xqiJVR3HhZFRaCiNEkyvc 0NekooyoZqVo1g5iQql54BEWmO3P/1ezfKjtjtbavh4AQ8+pMDW83dusKUDKBLTZegD9LJ 9EhTzGAeGtyM7zUtnWdp1KSofKMubIXeh9wmwaLHP+pD7Qni0RTPwY2C4wvUbQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by jhibbits: URL: https://cgit.FreeBSD.org/src/commit/?id=6db44b0158c37f2206f2c4ea7f29f5b774389e54 commit 6db44b0158c37f2206f2c4ea7f29f5b774389e54 Author: Justin Hibbits AuthorDate: 2022-02-10 15:21:36 +0000 Commit: Justin Hibbits CommitDate: 2022-02-10 15:34:37 +0000 Fix gzip compressed core dumps on big endian architectures The gzip trailer words (size and CRC) are both little-endian per the spec. MFC after: 3 days Sponsored by: Juniper Networks, Inc. --- sys/kern/subr_compressor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sys/kern/subr_compressor.c b/sys/kern/subr_compressor.c index b202d271cfa3..74526a949437 100644 --- a/sys/kern/subr_compressor.c +++ b/sys/kern/subr_compressor.c @@ -41,6 +41,7 @@ __FBSDID("$FreeBSD$"); #include #include +#include #include #include #include @@ -201,9 +202,9 @@ gz_write(void *stream, void *data, size_t len, compressor_cb_t cb, * Try to pack as much of the trailer into the * output buffer as we can. */ - ((uint32_t *)trailer)[0] = s->gz_crc; + ((uint32_t *)trailer)[0] = htole32(s->gz_crc); ((uint32_t *)trailer)[1] = - s->gz_stream.total_in; + htole32(s->gz_stream.total_in); room = MIN(sizeof(trailer), s->gz_bufsz - len); memcpy(s->gz_buffer + len, trailer, room);