From nobody Thu Feb 10 02:48:22 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D09BC19BE554; Thu, 10 Feb 2022 02:48:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JvLlp558Qz4mnw; Thu, 10 Feb 2022 02:48:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644461302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h5srfs6p7LHksBVAZ3TBo5wsCuOwxWs6I+42VqkTehg=; b=GuVFF74CahjONMnDTYQSBD5VwqgvKZSX0/fub2YweQglQsfLUs6DST4ZmxXuEkA30NRfP3 tyL+Ag6oaci3a+Wj87wU8u/Eo9P+eEEwMs7hE0rJuFHRvLm2dSob+5nzDeOhG352aB+CaR TP6f6gw7xvKw86cDa4ukFt2d1i+q15st+g0Y/21HuuzIn8qgEytQrTqgva/c4tBEHlT1+B 48eDYm6Ybl2rC0zQHFRz6y+nh0VyJ2562noqWcQd5fUmsp4uk2e8DnClCtn0OjQ0e15bE9 0yJc+b/MBAZKFRzdmv214nbm7dadSTh6+mvXb11kWwIaevoVsh8lq+ix7B9tfg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8A16718E15; Thu, 10 Feb 2022 02:48:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 21A2mMNq070399; Thu, 10 Feb 2022 02:48:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 21A2mMWw070398; Thu, 10 Feb 2022 02:48:22 GMT (envelope-from git) Date: Thu, 10 Feb 2022 02:48:22 GMT Message-Id: <202202100248.21A2mMWw070398@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Chuck Silvers Subject: git: f339a3ef6369 - main - dtrace: remove unnecessary fflush() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: chs X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f339a3ef6369b368f3a2455792a7a3a4c28f92c4 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1644461302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=h5srfs6p7LHksBVAZ3TBo5wsCuOwxWs6I+42VqkTehg=; b=hUphUQWrsmHAIfRV6p2ZuD7aJsy8X60ejtkysaW59WR69MFiCMAqpELgfW2K5T6XI1wojr +zkzlTJw/Y8wvuZOWCxi1TfMEi8O59fVy0eaqD5Hs9z7cBgDKSm2ux2shyVEBMVKKyEQ8K +k+V/BBiI/s+uzx4Wo77ZcXfNgwWK1F++H9/LUqZlRTfIf2HMAusf+dqkLrLXH1jU/9STh N3ptOVCSFmgwCymNfD7CbgvhEjmVFFdsXEPkOuCvA1OXKNhbcrk/+lNJYmwS5LzZXAqkc1 ODwBryf1zng4//0vhkh4lpzqKNQbYr9KZYPJBnW8gD/qAaTJ1wR69uuYG1FwwA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1644461302; a=rsa-sha256; cv=none; b=mVik9OK3KmX4/j4Eov03DSgOZCd1/O0zJ+MsOYAIHG38iB4/IecxPosucodWY2YNOTlzGr M03gMDzVszreR8CepPkWZzEVPNxGVXRfGzN+OPpEFP/4cTC6LJaSR6jBy5E9blizcMTGDQ Ub3hnSgYcJhHZzHO2hU5fjksOocoxehzv0nCi+Yn1krjALLrHNJk6JfF33d1lcp+Oq2Zh7 CbNIoEAOB00+fY+6Wmx+mH7k6Wxz7/SOaFE1zAEuewSP7POe3HgwQ7/BeqbnpP/NyA2JQ5 /mcqvEC4luzJp8gR4/s52WlYmOTLjcCqQZlnEHHG7LBXoEwiDT9AcocVIEUCZg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by chs: URL: https://cgit.FreeBSD.org/src/commit/?id=f339a3ef6369b368f3a2455792a7a3a4c28f92c4 commit f339a3ef6369b368f3a2455792a7a3a4c28f92c4 Author: Chuck Silvers AuthorDate: 2022-02-10 01:09:26 +0000 Commit: Chuck Silvers CommitDate: 2022-02-10 01:09:26 +0000 dtrace: remove unnecessary fflush() This call was added back in the early days of dtrace porting and no one knows why anymore. The extra flushing causes lots of unnecessary CPU overhead when a script produces lots of output, as well as easily losing output because the command can't keep up. Sponsored by: Netflix Reviewed by: imp, markj Differential Revision: https://reviews.freebsd.org/D34216 --- cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c index 2d8c24a0a596..1729eaf2e7be 100644 --- a/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c +++ b/cddl/contrib/opensolaris/lib/libdtrace/common/dt_subr.c @@ -694,7 +694,6 @@ dt_printf(dtrace_hdl_t *dtp, FILE *fp, const char *format, ...) va_copy(ap2, ap); n = vfprintf(fp, format, ap2); - fflush(fp); va_end(ap2); va_end(ap);