From nobody Tue Feb 01 04:55:10 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C7230198F4C2; Tue, 1 Feb 2022 04:55:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Jnt0H51syz3kZc; Tue, 1 Feb 2022 04:55:11 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643691312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVn9r5jeUFExqEp/9jietOLCLMDJ5ieqVKF/exuKtQw=; b=js+8mSL2P8TvUs8/jQCsnn+yyJzfz9y3JcsKUrxhTQig3h3mmqI4hnXabpG6ldQNNNSB7Y 6tVXx3YB513xt6hQnbnRCFOQZpqhX1d0XvmgOCWfQJ2HBnr9L2HVO6Opv0j1ky6FekCsnx 45p1DqweSSjhFyLF4WvWj/iVcRnIsSQj4UuvtE/n/g76kTLaJ9hxDEvEuqBbHRGzdFmg7z gavTajXcFEeCESkZXOMj7uomAIlMfl6j2X0QPoKEq3ZYJtaw6polu5ARl8JFVtEKkfZ1pi sjDhacgs8bAFZQH04bBnbPVGleXiMacybDPBX+SHPPGHwetyFHmzvCHpETQ99w== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8F7451EA0; Tue, 1 Feb 2022 04:55:10 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 2114tAhD007917; Tue, 1 Feb 2022 04:55:10 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 2114tApR007916; Tue, 1 Feb 2022 04:55:10 GMT (envelope-from git) Date: Tue, 1 Feb 2022 04:55:10 GMT Message-Id: <202202010455.2114tApR007916@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 99aa3b731caa - main - ffs: lock buffers after snaplk with LK_NOWITNESS List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 99aa3b731caa252e94d92add8cb02d077a24a256 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1643691312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HVn9r5jeUFExqEp/9jietOLCLMDJ5ieqVKF/exuKtQw=; b=b6B3WkJETH19hc30IOJRUmMU+WhHws38tx4WMh4qpjvYMGZX+cPYVatqMpo5I9M9xGUePi gHyQtbhq6iIvrBAe8mqnawScnselxzSUp+nVHJcyHtFaj5t2ufB4Dot2zRCAM4FDIQck45 CFuD5vA8RRopSW8JhGGah82iwmhOkG/KadTrPwZA//rcMTHjHbtlTRzh0M/EAcDozSalrh roG6bLp+WLr3+kafCwkVmHm8HmlNICZtqLzGe18drz7PwBA9NSRRkV/8OHA+FUl5ciHFwV Br45BMrB/+4y/BRnKJMbKbw4VXgpfl7XCX2qQpLMRxl6JEksr6mTibqSvNg/qA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1643691312; a=rsa-sha256; cv=none; b=UIO3hX6T/1+BQilqc1IueSwrfZjPr1EqzuaiHhyqn0JdOwPgKTwAhD9F+xnOwu3PD8TKp9 BsgaNxlqT4elkc/bz2SdWHrDutfDbAMZpuPLNn0BjXkec1Ygz200ycs6nOidkqHQDgA/xi pcu7VTalCtBKmSLF1H1n4MeN7t+BlodD+ea8sNTRy9K6vq4f97FWtndf5WJGoazr6fUPtG FCDYJoMVUsGc849jvJnQcIlOVKvqQvCEffYKS+ap74DT5cVBPmTtg6Li5MF02iIpnja9z+ XcvtwuLO0LBr+LeAu8XQAGMfekjAE1uu5ZGQRUQvgBuwW06m28d9/5gAvcI3fQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=99aa3b731caa252e94d92add8cb02d077a24a256 commit 99aa3b731caa252e94d92add8cb02d077a24a256 Author: Konstantin Belousov AuthorDate: 2022-01-28 04:42:33 +0000 Commit: Konstantin Belousov CommitDate: 2022-02-01 04:54:50 +0000 ffs: lock buffers after snaplk with LK_NOWITNESS Reviewed by: mckusick Discussed with: markj Tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 1 week Differential revision: https://reviews.freebsd.org/D34073 --- sys/ufs/ffs/ffs_alloc.c | 4 ++++ sys/ufs/ffs/ffs_balloc.c | 23 +++++++++++++++-------- sys/ufs/ffs/ffs_vnops.c | 12 ++++++++---- 3 files changed, 27 insertions(+), 12 deletions(-) diff --git a/sys/ufs/ffs/ffs_alloc.c b/sys/ufs/ffs/ffs_alloc.c index 13c508fde646..50b176b262f4 100644 --- a/sys/ufs/ffs/ffs_alloc.c +++ b/sys/ufs/ffs/ffs_alloc.c @@ -80,6 +80,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include #include #include @@ -270,6 +271,9 @@ ffs_realloccg(ip, lbprev, bprev, bpref, osize, nsize, flags, cred, bpp) fs = ump->um_fs; bp = NULL; gbflags = (flags & BA_UNMAPPED) != 0 ? GB_UNMAPPED : 0; +#ifdef WITNESS + gbflags |= IS_SNAPSHOT(ip) ? GB_NOWITNESS : 0; +#endif mtx_assert(UFS_MTX(ump), MA_OWNED); #ifdef INVARIANTS diff --git a/sys/ufs/ffs/ffs_balloc.c b/sys/ufs/ffs/ffs_balloc.c index d7718e56dd87..af20258081d5 100644 --- a/sys/ufs/ffs/ffs_balloc.c +++ b/sys/ufs/ffs/ffs_balloc.c @@ -70,6 +70,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include #include @@ -612,7 +613,7 @@ ffs_balloc_ufs2(struct vnode *vp, off_t startoffset, int size, int deallocated, osize, nsize, num, i, error; int unwindidx = -1; int saved_inbdflush; - int gbflags, reclaimed; + int gbflags, gbwflag, reclaimed; ip = VTOI(vp); dp = ip->i_din2; @@ -628,6 +629,12 @@ ffs_balloc_ufs2(struct vnode *vp, off_t startoffset, int size, if (lbn < 0) return (EFBIG); gbflags = (flags & BA_UNMAPPED) != 0 ? GB_UNMAPPED : 0; +#ifdef WITNESS + gbwflag = IS_SNAPSHOT(ip) ? GB_NOWITNESS : 0; + gbflags |= gbwflag; +#else + gbwflag = 0; +#endif vn_seqc_write_begin(vp); @@ -889,7 +896,7 @@ ffs_balloc_ufs2(struct vnode *vp, off_t startoffset, int size, *allocblk++ = nb; *lbns_remfree++ = indirs[1].in_lbn; bp = getblk(vp, indirs[1].in_lbn, fs->fs_bsize, 0, 0, - GB_UNMAPPED); + GB_UNMAPPED | gbwflag); bp->b_blkno = fsbtodb(fs, nb); vfs_bio_clrbuf(bp); if (DOINGSOFTDEP(vp)) { @@ -914,8 +921,8 @@ ffs_balloc_ufs2(struct vnode *vp, off_t startoffset, int size, */ retry: for (i = 1;;) { - error = bread(vp, - indirs[i].in_lbn, (int)fs->fs_bsize, NOCRED, &bp); + error = bread_gb(vp, indirs[i].in_lbn, (int)fs->fs_bsize, + NOCRED, gbwflag, &bp); if (error) { goto fail; } @@ -1138,7 +1145,7 @@ fail: * buffer object lists. */ bp = getblk(vp, *lbns_remfree, fs->fs_bsize, 0, 0, - GB_NOCREAT | GB_UNMAPPED); + GB_NOCREAT | GB_UNMAPPED | gbwflag); if (bp != NULL) { KASSERT(bp->b_blkno == fsbtodb(fs, *blkp), ("mismatch2 l %jd %jd b %ju %ju", @@ -1156,8 +1163,8 @@ fail: } else if (unwindidx >= 0) { int r; - r = bread(vp, indirs[unwindidx].in_lbn, - (int)fs->fs_bsize, NOCRED, &bp); + r = bread_gb(vp, indirs[unwindidx].in_lbn, + (int)fs->fs_bsize, NOCRED, gbwflag, &bp); if (r) { panic("Could not unwind indirect block, error %d", r); brelse(bp); @@ -1193,7 +1200,7 @@ fail: if (blkp == allociblk) lbns_remfree = lbns; bp = getblk(vp, *lbns_remfree, fs->fs_bsize, 0, 0, - GB_NOCREAT | GB_UNMAPPED); + GB_NOCREAT | GB_UNMAPPED | gbwflag); if (bp != NULL) { panic("zombie2 %jd %ju %ju", (intmax_t)bp->b_lblkno, (uintmax_t)bp->b_blkno, diff --git a/sys/ufs/ffs/ffs_vnops.c b/sys/ufs/ffs/ffs_vnops.c index 0a2cd5970906..66dafed5ac9e 100644 --- a/sys/ufs/ffs/ffs_vnops.c +++ b/sys/ufs/ffs/ffs_vnops.c @@ -261,12 +261,17 @@ ffs_syncvnode(struct vnode *vp, int waitfor, int flags) struct ufsmount *ump; struct buf *bp, *nbp; ufs_lbn_t lbn; - int error, passes; + int error, passes, wflag; bool still_dirty, unlocked, wait; ip = VTOI(vp); bo = &vp->v_bufobj; ump = VFSTOUFS(vp->v_mount); +#ifdef WITNESS + wflag = IS_SNAPSHOT(ip) ? LK_NOWITNESS : 0; +#else + wflag = 0; +#endif /* * When doing MNT_WAIT we must first flush all dependencies @@ -318,9 +323,8 @@ loop: if (BUF_LOCK(bp, LK_EXCLUSIVE | LK_NOWAIT, NULL) == 0) { BO_UNLOCK(bo); } else if (wait) { - if (BUF_LOCK(bp, - LK_EXCLUSIVE | LK_SLEEPFAIL | LK_INTERLOCK, - BO_LOCKPTR(bo)) != 0) { + if (BUF_LOCK(bp, LK_EXCLUSIVE | LK_SLEEPFAIL | + LK_INTERLOCK | wflag, BO_LOCKPTR(bo)) != 0) { BO_LOCK(bo); bp->b_vflags &= ~BV_SCANNED; goto next_locked;