From nobody Tue Dec 06 17:35:10 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4NRSH66jtyz4jTCn; Tue, 6 Dec 2022 17:35:14 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta002.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4NRSH53kbwz4JWT; Tue, 6 Dec 2022 17:35:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 3.97.99.33) smtp.mailfrom=cy.schubert@cschubert.com; dmarc=none Received: from shw-obgw-4002a.ext.cloudfilter.net ([10.228.9.250]) by cmsmtp with ESMTP id 2YbXpNV4dyQ9e2bqapW5ZC; Tue, 06 Dec 2022 17:35:12 +0000 Received: from spqr.komquats.com ([70.66.148.124]) by cmsmtp with ESMTPA id 2bqYpvk78omIw2bqZpvfWP; Tue, 06 Dec 2022 17:35:12 +0000 X-Authority-Analysis: v=2.4 cv=LM91/ba9 c=1 sm=1 tr=0 ts=638f7d50 a=Cwc3rblV8FOMdVN/wOAqyQ==:117 a=Cwc3rblV8FOMdVN/wOAqyQ==:17 a=kj9zAlcOel0A:10 a=sHyYjHe8cH0A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=ODBkek-OkRL3UJffCFQA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 85352296; Tue, 6 Dec 2022 09:35:10 -0800 (PST) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 6CE0010D; Tue, 6 Dec 2022 09:35:10 -0800 (PST) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jung-uk Kim cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 9a4bc5208fad - main - acpica: Import ACPICA 20221020 In-reply-to: <202210280205.29S25MZ5011058@gitrepo.freebsd.org> References: <202210280205.29S25MZ5011058@gitrepo.freebsd.org> Comments: In-reply-to Jung-uk Kim message dated "Fri, 28 Oct 2022 02:05:22 +0000." List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 06 Dec 2022 09:35:10 -0800 Message-Id: <20221206173510.6CE0010D@slippy.cwsent.com> X-CMAE-Envelope: MS4xfG/oAvyZvgqsQcHCvnh/W4hzVneqId0TAXaTLy2ndakjkFYL4CFHR31uTL/c7kxIn9LhE3IimybD8Gz1fVkKJWylz11Q41ykzcvvl2jZis4m/7pDp2u8 fic5faj/f7b226tmkWY04GKcWcF08c9DZMdju7V485rD45bbzCIsbR1K2ExAZmTQk/N2ZrvVzuFEYlaFjMjZ5+Y/NiwDmzXnx2gldsqbKjClmxGj+tNEiZp3 PIz52QbhPM+5z64uNUR3jApouqB8xCgzvt44bz8e8wbqUCBN6H08ZbIm7Q24Gj2GKvTdq7WvG7tEsMOMbX8bdbf57PqK1X2RUvdD8wmb2w8= X-Spamd-Result: default: False [-1.70 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_SHORT(-1.00)[-0.999]; MV_CASE(0.50)[]; RCVD_IN_DNSWL_LOW(-0.10)[3.97.99.33:from]; MIME_GOOD(-0.10)[text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; R_SPF_NA(0.00)[no SPF record]; TO_DN_SOME(0.00)[]; ARC_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_LAST(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com] X-Rspamd-Queue-Id: 4NRSH53kbwz4JWT X-Spamd-Bar: - X-ThisMailContainsUnwantedMimeParts: N In message <202210280205.29S25MZ5011058@gitrepo.freebsd.org>, Jung-uk Kim write s: > The branch main has been updated by jkim: > > URL: https://cgit.FreeBSD.org/src/commit/?id=9a4bc5208fad4d69360dbbe769e28a37 > 419c4e21 > > commit 9a4bc5208fad4d69360dbbe769e28a37419c4e21 > Author: Jung-uk Kim > AuthorDate: 2022-10-27 21:34:40 +0000 > Commit: Jung-uk Kim > CommitDate: 2022-10-28 02:03:50 +0000 > > acpica: Import ACPICA 20221020 > > (cherry picked from commit a799bdd9d50e84cd6a36e8f1d2ac4301b2a6b374) > --- > sys/contrib/dev/acpica/common/acfileio.c | 131 ++++++-- > sys/contrib/dev/acpica/common/adisasm.c | 4 +- > sys/contrib/dev/acpica/common/ahtable.c | 2 + > sys/contrib/dev/acpica/common/ahuuids.c | 3 + > sys/contrib/dev/acpica/common/dmtable.c | 116 ++++--- > sys/contrib/dev/acpica/common/dmtables.c | 2 +- > sys/contrib/dev/acpica/common/dmtbdump.c | 4 +- > sys/contrib/dev/acpica/common/dmtbdump1.c | 205 ++++++++++++- > sys/contrib/dev/acpica/common/dmtbdump2.c | 100 ++++-- > sys/contrib/dev/acpica/common/dmtbinfo1.c | 110 +++++++ > sys/contrib/dev/acpica/common/dmtbinfo2.c | 33 +- > sys/contrib/dev/acpica/common/dmtbinfo3.c | 17 ++ > sys/contrib/dev/acpica/compiler/aslcodegen.c | 75 ++++- > sys/contrib/dev/acpica/compiler/aslcompile.c | 12 +- > sys/contrib/dev/acpica/compiler/aslerror.c | 1 - > sys/contrib/dev/acpica/compiler/aslhelp.c | 1 + > sys/contrib/dev/acpica/compiler/asloptions.c | 30 +- > sys/contrib/dev/acpica/compiler/aslpredef.c | 2 +- > sys/contrib/dev/acpica/compiler/aslprune.c | 8 + > sys/contrib/dev/acpica/compiler/aslstartup.c | 2 +- > sys/contrib/dev/acpica/compiler/dtcompile.c | 42 +++ > sys/contrib/dev/acpica/compiler/dtcompiler.h | 10 + > sys/contrib/dev/acpica/compiler/dtio.c | 2 +- > sys/contrib/dev/acpica/compiler/dttable1.c | 128 +++++++- > sys/contrib/dev/acpica/compiler/dttable2.c | 169 +++++++++-- > sys/contrib/dev/acpica/compiler/dttemplate.h | 63 +++- > sys/contrib/dev/acpica/compiler/dtutils.c | 3 +- > .../dev/acpica/components/debugger/dbutils.c | 192 ++++++++++++ > sys/contrib/dev/acpica/components/events/evevent.c | 11 +- > .../dev/acpica/components/events/evregion.c | 8 + > .../dev/acpica/components/executer/exfield.c | 6 +- > .../dev/acpica/components/executer/exserial.c | 6 + > .../dev/acpica/components/hardware/hwsleep.c | 10 + > sys/contrib/dev/acpica/components/tables/tbdata.c | 2 +- > sys/contrib/dev/acpica/components/tables/tbfadt.c | 2 +- > sys/contrib/dev/acpica/components/tables/tbprint.c | 90 +----- > sys/contrib/dev/acpica/components/tables/tbutils.c | 2 +- > .../dev/acpica/components/tables/tbxfroot.c | 32 +- > .../dev/acpica/components/utilities/utcksum.c | 335 +++++++++++++++++++ > ++ > .../dev/acpica/components/utilities/utglobal.c | 1 + > .../dev/acpica/components/utilities/utstring.c | 10 +- > sys/contrib/dev/acpica/include/acconfig.h | 2 + > sys/contrib/dev/acpica/include/acdisasm.h | 19 ++ > sys/contrib/dev/acpica/include/acglobal.h | 1 + > sys/contrib/dev/acpica/include/acpixf.h | 2 +- > sys/contrib/dev/acpica/include/actables.h | 10 - > sys/contrib/dev/acpica/include/actbinfo.h | 10 + > sys/contrib/dev/acpica/include/actbl1.h | 179 ++++++++++- > sys/contrib/dev/acpica/include/actbl2.h | 163 +++++++++- > sys/contrib/dev/acpica/include/actypes.h | 9 +- > sys/contrib/dev/acpica/include/acutils.h | 25 ++ > sys/contrib/dev/acpica/include/acuuid.h | 3 +- > 52 files changed, 2121 insertions(+), 284 deletions(-) This broke Wake-on-LAN on my Acer laptop. Sending a WOL signal to the laptop fails to wake the machine. However, pulling the power cord, plugging it back in, and then sending a WOL signal does wake it. This led me to believe this commit was the cause of the problem. To remediate I applied the following patch, essentially reverting two small patches within this commit. This fixes my WOL problem. diff --git a/sys/contrib/dev/acpica/components/events/evevent.c b/sys/contrib/dev/acpica/components/events/evevent.c index 07c06c7c7839..1eb1262b92ea 100644 --- a/sys/contrib/dev/acpica/components/events/evevent.c +++ b/sys/contrib/dev/acpica/components/events/evevent.c @@ -312,8 +312,7 @@ AcpiEvFixedEventInitialize ( { Status = AcpiWriteBitRegister ( AcpiGbl_FixedEventInfo[i].EnableRegisterId, - (i == ACPI_EVENT_PCIE_WAKE) ? - ACPI_ENABLE_EVENT : ACPI_DISABLE_EVENT); + ACPI_DISABLE_EVENT); if (ACPI_FAILURE (Status)) { return (Status); @@ -437,8 +436,7 @@ AcpiEvFixedEventDispatch ( { (void) AcpiWriteBitRegister ( AcpiGbl_FixedEventInfo[Event].EnableRegisterId, - (Event == ACPI_EVENT_PCIE_WAKE) ? - ACPI_ENABLE_EVENT : ACPI_DISABLE_EVENT); + ACPI_DISABLE_EVENT); ACPI_ERROR ((AE_INFO, "No installed handler for fixed event - %s (%u), disabling", -- -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0