git: b43cfe717130 - main - ada/da: Borrow comment from nda about cleanup
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 24 Apr 2022 21:12:23 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=b43cfe717130606a2dce85bcd22c362dfe598733
commit b43cfe717130606a2dce85bcd22c362dfe598733
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2022-04-24 21:11:56 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2022-04-24 21:11:56 +0000
ada/da: Borrow comment from nda about cleanup
Remove a XXX comment and replace it with a more accurate comment about
what happens to I/O queued to the hardware.
Sponsored by: Netflix
---
sys/cam/ata/ata_da.c | 7 ++++---
sys/cam/scsi/scsi_da.c | 7 ++++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/sys/cam/ata/ata_da.c b/sys/cam/ata/ata_da.c
index 2623d8919e06..efca987b39b4 100644
--- a/sys/cam/ata/ata_da.c
+++ b/sys/cam/ata/ata_da.c
@@ -1240,9 +1240,10 @@ adaoninvalidate(struct cam_periph *periph)
#endif
/*
- * Return all queued I/O with ENXIO.
- * XXX Handle any transactions queued to the card
- * with XPT_ABORT_CCB.
+ * Return all queued I/O with ENXIO. Transactions may be queued up here
+ * for retry (since we are called while there's other transactions
+ * pending). Any requests in the hardware will drain before ndacleanup
+ * is called.
*/
cam_iosched_flush(softc->cam_iosched, NULL, ENXIO);
diff --git a/sys/cam/scsi/scsi_da.c b/sys/cam/scsi/scsi_da.c
index 6531a7fa9d12..ed71a25cd657 100644
--- a/sys/cam/scsi/scsi_da.c
+++ b/sys/cam/scsi/scsi_da.c
@@ -2055,9 +2055,10 @@ daoninvalidate(struct cam_periph *periph)
#endif
/*
- * Return all queued I/O with ENXIO.
- * XXX Handle any transactions queued to the card
- * with XPT_ABORT_CCB.
+ * Return all queued I/O with ENXIO. Transactions may be queued up here
+ * for retry (since we are called while there's other transactions
+ * pending). Any requests in the hardware will drain before dacleanup
+ * is called.
*/
cam_iosched_flush(softc->cam_iosched, NULL, ENXIO);