From nobody Tue Apr 19 11:08:20 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 92F6111D3A69; Tue, 19 Apr 2022 11:08:26 +0000 (UTC) (envelope-from se@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KjLdQ3bqNz3Mmd; Tue, 19 Apr 2022 11:08:26 +0000 (UTC) (envelope-from se@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650366506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k2iK3MyhAqTELQ1TW7NA4+Yd82a5SyIr6BO6YOM21bM=; b=hvQZA1gM1OlkwKbJYX2dX2hKlZF/qI8WBSIzOsMM4KKiQ9H3wu+DwUJ7yVMXPtHd5KDOts rhX86lYtpUGchIZbrrWHlXrTdsAFcycm0hRlM16ZjssLSpLNsVTsnYtgfpHgqk88uDilcV Gh3724B80cXzFSU7EcSigfYnoYDO0kaBlwLUKIsOcm1rRuU+OTqVM6QrBSncnFRsrlKlJA mzFyvvNT259TyIfXOGH5Pa0YImZMrOMfvMzUa3JArIgGJManQXd83P15iofCGGwMKh4f7t 6tUykgsSTiCdUNdweCFLvzXfLBP6258A0Oj2QPEptGouuQKE+pAsDlYFwSWynw== Received: from [IPV6:2003:cd:5f27:b000:dddd:15c1:5d71:138c] (p200300cd5f27b000dddd15c15d71138c.dip0.t-ipconnect.de [IPv6:2003:cd:5f27:b000:dddd:15c1:5d71:138c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8A62F7CB1; Tue, 19 Apr 2022 11:08:25 +0000 (UTC) (envelope-from se@FreeBSD.org) Message-ID: <960b9be3-c3b5-bd48-8038-97511f2f7909@FreeBSD.org> Date: Tue, 19 Apr 2022 13:08:20 +0200 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. Content-Language: en-US To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> From: Stefan Esser In-Reply-To: <202204182311.23INBqfC025671@gitrepo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------rkd0gpIA3bxev9OJKv8FhvEO" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1650366506; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=k2iK3MyhAqTELQ1TW7NA4+Yd82a5SyIr6BO6YOM21bM=; b=vpFd7CdsWjkt6/E87k1JP6spH9D7ZvqeErIAFQrDSybkqb1ifUKiuc1Q4y3gQxUJrtBC0I WwEyOo1NuntSbykMCNk6/tAoqRb4iJMIyNvEve2nYItf50ClcEp4DvIApwcc6pA7nK8VhC XZ0xeWCHnYSRUhq3vOYfYlzegPcIb2DD+9gdjg8Z4WERy6Avhn9Em52xrlebzLa9glZrI5 /fjYj8KjsfkF6ysneDYqTZf8FWimRZSqEOYEpC9AR1ISQJ8FFTx2qrdur/B9o2scCrV1lA /wEyTjuzO4pbmH68cNdt4l2CsA53Iil319HJzBbO6KAcUwfRIz8ZrfOEDog2Zg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1650366506; a=rsa-sha256; cv=none; b=soeqWlUSjPdSyBtFQUqTpq42tarXdtp6Xlw0ZdYIeNQvEZDaS7JUhZGln+kV6ZjfTzJLPU GCSI8zPil9klXbnUZ6CLzpCF/DNY4HlKxUr8Q3IlF+5zmlnJxpSb4sod5Legm8vcC6eNI/ 7ogJXsblI9eYIcMGJH5XpjoUjdP8xlptnYqVrV2XW0vyu/YQSLPN1YdnTOrbfSGpm8HJgq S6xFP4lCwvodY/foih8dhHMpX/2pNKSrRMhkE+HzyDP0IXJszdgXGF4oyuIPToXTy96oIc xPSBlU/VAOMs/Bz8WvK98h7Luvb8LWCYN8VRQ0/wTgewHUMXOeolpUy0o9yDNA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------rkd0gpIA3bxev9OJKv8FhvEO Content-Type: multipart/mixed; boundary="------------HZ2UMqEig5zZ03gEPFti4BiZ"; protected-headers="v1" From: Stefan Esser To: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Message-ID: <960b9be3-c3b5-bd48-8038-97511f2f7909@FreeBSD.org> Subject: Re: git: 8b83d7e0ee54 - main - Make -Wunused-but-set-variable a fatal error for clang 13+ for kernel builds. References: <202204182311.23INBqfC025671@gitrepo.freebsd.org> In-Reply-To: <202204182311.23INBqfC025671@gitrepo.freebsd.org> --------------HZ2UMqEig5zZ03gEPFti4BiZ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Am 19.04.22 um 01:11 schrieb John Baldwin: > The branch main has been updated by jhb: >=20 > URL: https://cgit.FreeBSD.org/src/commit/?id=3D8b83d7e0ee54416b0ee58bd8= 5f9c0ae7fb3357a1 >=20 > commit 8b83d7e0ee54416b0ee58bd85f9c0ae7fb3357a1 > Author: John Baldwin > AuthorDate: 2022-04-18 23:06:27 +0000 > Commit: John Baldwin > CommitDate: 2022-04-18 23:06:27 +0000 >=20 > Make -Wunused-but-set-variable a fatal error for clang 13+ for kern= el builds. > =20 > Reviewed by: imp, emaste > Differential Revision: https://reviews.freebsd.org/D34949 I'm seeing kernel build issues in several drivers (at commit f2edc9155721= ). The first one could be fixed this way: diff --git a/sys/dev/cxgbe/tom/t4_cpl_io.c b/sys/dev/cxgbe/tom/t4_cpl_io.= c index 4c8b1fa27579..470f03313b72 100644 --- a/sys/dev/cxgbe/tom/t4_cpl_io.c +++ b/sys/dev/cxgbe/tom/t4_cpl_io.c @@ -2192,7 +2192,7 @@ static void t4_aiotx_process_job(struct toepcb *toep, struct socket *so, struct kaio= cb *job) { struct sockbuf *sb; +#ifdef MAC struct file *fp; +#endif struct inpcb *inp; struct tcpcb *tp; struct mbuf *m; @@ -2201,10 +2201,10 @@ t4_aiotx_process_job(struct toepcb *toep, struct = socket *so, struct kaiocb *job) sb =3D &so->so_snd; SOCKBUF_UNLOCK(sb); - fp =3D job->fd_file; m =3D NULL; #ifdef MAC + fp =3D job->fd_file; error =3D mac_socket_check_send(fp->f_cred, so); if (error !=3D 0) goto out; But then the build failed again at: /usr/src/sys/fs/ext2fs/ext2_extents.c:452:8: error: variable 'error_msg' = set but not used [-Werror,-Wunused-but-set-variable] Building /usr/obj/usr-14/git/src/amd64.amd64/sys/SE/vdev_mirror.o I have stopped trying to fix this and (any remaining) issues and have locally reverted the commit that made this warning fatal ... Regards, STefan --------------HZ2UMqEig5zZ03gEPFti4BiZ-- --------------rkd0gpIA3bxev9OJKv8FhvEO Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAmJemCQFAwAAAAAACgkQR+u171r99URF 9gf/Qv9cVZzz2qYxZcqRPkpuxvVLP1Ro4uCGzUBKmbip1G3vn6Mkd9Eq7T9ALNECvOj3BueMD13p 1MGjiASQYxozhTLpeCmXHDYrGLIEYk//u16ksEu5u1qJa3p7IErBfmgcLyDl3sZO51qGrGFe2/HW qz+rE3KgoSoRG/Qx1QycBuDgqdRJS1dujHuWUqjGtBUHkH+Bz9gIdY2sB5kBvoMOKLRMXxlNktVi MdPDi3jFL8wiyWCVfBHPQqnElLBoxSCJC4IKBBw0Kofq25z5NpXqnGEP3C2Hy0Y0hvI+OkFlzpOc UqDRx2GxHgO4gTkh4WRqdREA6XvIwxeFVtY9shyETA== =2Rh/ -----END PGP SIGNATURE----- --------------rkd0gpIA3bxev9OJKv8FhvEO--