From nobody Sun Oct 17 15:13:20 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4693F180364D; Sun, 17 Oct 2021 15:13:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXNn01VW3z4mmd; Sun, 17 Oct 2021 15:13:24 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.codepro.be", Issuer "R3" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id EE516727B; Sun, 17 Oct 2021 15:13:23 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id DBCA5197F2; Sun, 17 Oct 2021 17:13:21 +0200 (CEST) From: Kristof Provost To: Shawn Webb Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 076b3a50fd71 - main - pf: don't drop packets when redirection information comes from a state Date: Sun, 17 Oct 2021 17:13:20 +0200 X-Mailer: MailMate (1.14r5818) Message-ID: <336ECE44-FD7F-417B-827A-236FC6224E5B@FreeBSD.org> In-Reply-To: <20211016231207.s6rw6ndjrsshya2r@mutt-hbsd> References: <202110162306.19GN6MLj036119@gitrepo.freebsd.org> <20211016231207.s6rw6ndjrsshya2r@mutt-hbsd> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On 17 Oct 2021, at 1:12, Shawn Webb wrote: > On Sat, Oct 16, 2021 at 11:06:22PM +0000, Kristof Provost wrote: >> The branch main has been updated by kp: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=3D076b3a50fd71d84f47bca71= 758e7fff3c02582e9 >> >> commit 076b3a50fd71d84f47bca71758e7fff3c02582e9 >> Author: Kristof Provost >> AuthorDate: 2021-10-16 16:53:39 +0000 >> Commit: Kristof Provost >> CommitDate: 2021-10-16 21:02:26 +0000 >> >> pf: don't drop packets when redirection information comes from a s= tate >> >> For some traffic there might be no matching rule in the current ru= leset, >> for example when a state was imported via pfsync from a sytem with= a >> different ruleset checksum. In this case pf_route uses s->rt_addr = for >> routing target instead of r->rpool.cur but r->rpool is checked any= way, >> resulting in dropped packets. >> >> PR: 259183 >> Submitted by: Kajetan Staszkiewicz >> Sponsored by: InnoGames GmbH > > Hey Kristof, > > Any plans to MFC? > I wasn=E2=80=99t planning to, but if it=E2=80=99d fix a problem for you r= emind me to MFC it in a week. Br, Kristof