From nobody Mon Oct 11 21:09:58 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EBED917F5364; Mon, 11 Oct 2021 21:09:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HSrzC69KVz3G7y; Mon, 11 Oct 2021 21:09:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 3F2733482; Mon, 11 Oct 2021 21:09:59 +0000 (UTC) (envelope-from jhb@FreeBSD.org) To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202110101934.19AJYuIJ019276@gitrepo.freebsd.org> From: John Baldwin Subject: Re: git: e81e77c5a055 - main - Enable PPS_SYNC on amd64, arm64 and armv7 Message-ID: <9f4710f1-4639-92ec-2040-51ea0bf9290c@FreeBSD.org> Date: Mon, 11 Oct 2021 14:09:58 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 10/11/21 1:46 PM, Konstantin Belousov wrote: > On Mon, Oct 11, 2021 at 01:37:21PM -0700, John Baldwin wrote: >> On 10/10/21 12:34 PM, Konstantin Belousov wrote: >>> The branch main has been updated by kib: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f >>> >>> commit e81e77c5a055d1cbf6d6a6f0acbaf443267aa84f >>> Author: Konstantin Belousov >>> AuthorDate: 2021-10-10 12:20:45 +0000 >>> Commit: Konstantin Belousov >>> CommitDate: 2021-10-10 19:34:40 +0000 >>> >>> Enable PPS_SYNC on amd64, arm64 and armv7 >>> Remove the option from NOTES/LINT, and add to NOTES for powerpc and >>> riscv. >>> PR: 259036 >>> Requested by: John Hay >>> Discussed with: ian, imp >>> Sponsored by: The FreeBSD Foundation >>> MFC after: 1 week >> >> Hmm, if the option is MI, why move it out of the MI NOTES? We don't >> generally remove items from NOTES just because they are enabled by default >> in GENERIC. That would break the functionality of NOTES where it documents >> options (and sometimes provides more detail than the 1-liner comments we >> use in GENERIC). >> >> In this case I would have left NOTES as-is and instead added PPS_SYNC to >> the relevant GENERIC files with a one-line comment leaving the more >> detailed comment in NOTES. > > To have both PPS_SYNC and !PPS_SYNC covered during tinderbox. > If an option is present in both NOTES and GENERIC, there is a chance > that its absence is not compiled.> > Bruce' opinion was that LINT should be mostly complementary to GENERIC. That doesn't match what we actually do. For example, INET and INET6 are in both, SMP, SOFTUPDATES, etc. I think you can go through amd64 GENERIC and every option in it is in NOTES except now for PPS_SYNC. I ran this before your commit: % awk '/^(device|options)/ { print $2 }' GENERIC | sort > one % awk '/^(device|options)/ { print $2 }' ../../conf/NOTES ../../x86/conf/NOTES NOTES | sort > two Items only in GENERIC (I would say most of these are probably bugs in the form of missing entries in NOTES, ULE is 4BSD in NOTES instead, and VERBOSE_SYSINIT has the default value of 1 in NOTES): % > comm -23 one two AH_AR5416_INTERRUPT_MITIGATION ATH_ENABLE_11N BUF_TRACKING DDB_CTF FIB_ALGO FULL_BUF_TRACKING IOMMU KDTRACE_FRAME PRINTF_BUFR_SIZE=128 RACCT_DEFAULT_TO_DISABLED SCHED_ULE VERBOSE_SYSINIT=0 ath_pci ocs_fc pvscsi tws vge The number of options duplicated in both NOTES and GENERIC: % comm -12 one two | wc -l 259 -- John Baldwin