From nobody Fri Nov 26 14:24:04 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 3B05D18A2C9E; Fri, 26 Nov 2021 14:24:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4J0xnd2ZfQz4cKK; Fri, 26 Nov 2021 14:24:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 860C22275; Fri, 26 Nov 2021 14:24:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1AQEO4Lp002519; Fri, 26 Nov 2021 14:24:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1AQEO4b8002518; Fri, 26 Nov 2021 14:24:04 GMT (envelope-from git) Date: Fri, 26 Nov 2021 14:24:04 GMT Message-Id: <202111261424.1AQEO4b8002518@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: aeacf172fd29 - main - twsi: remove redundant write of control register List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: aeacf172fd29b16b3661ff057c9abb238baba813 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637936646; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=n0Bh76MSFGKfE2a9lr0vk5u7kVu3pY/hDIUWDUMkcWQ=; b=H3sr38mc0Jv1ju7RX9anFqCREAaDZMwadVPvE80O7dOZjuVrjLRRkvDAga/jNY5DGdC75v lHDGsJX9rHxlgmfwMXxYyVWqG9QxUYUCn/Mb4XX8tnIbe3D28iCFBw0tZEsuQjtACPguti f0Xth5bfoeBIRn8+uhUYUGW1fY9McNnPbaKj4LaijVQKYs+upny7lSu6V8QlEEN7oQS5zZ FHGZ0/nmxaesH9XGBPYWCgW4+96QgTC/eSmATB3wJ7ppEo7Wguc1FY4k4JS7T5vozUmNq+ TCw+7lbOXkk+fpUURLQvSJ9qzTcrVAa+6j/I7JKsonBtNkBHSyhKRJ0Yc1LZag== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637936646; a=rsa-sha256; cv=none; b=VV71qbQksrAS7yOMq68GWTOGvxXVVtcSD2Y5YtZK9iDTqcJfVd56ozCBUS3F0uDy+otqBJ bWduOUFhFo+9Pc3Vk2d7xKpPtbyKBDlFlYMDHmAVLJoOlh23Oiz8zpHsoPk5XZR+FHTQWC di3rqIBO54RVGuz42yM5Bp1wo96xVgyR1S1CA6xDnJU03nkeSXNPp8oEwrQ5cmTRRRcN/r 0pUxc+jTdPRty7+hB+FewmQVN+0h1IGlUSrLnWreRxYtdhpAVSJquRabQV7HG016o+FX77 yH4dhA6u/ChEbv8UxqAlZt2jiz1zE8nNaT+aylQei50HTzB8deyclFmHHeqtkw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=aeacf172fd29b16b3661ff057c9abb238baba813 commit aeacf172fd29b16b3661ff057c9abb238baba813 Author: Andriy Gapon AuthorDate: 2021-11-26 08:09:59 +0000 Commit: Andriy Gapon CommitDate: 2021-11-26 14:18:30 +0000 twsi: remove redundant write of control register The write at the end of twsi_intr() already handles all cases, no need to have another write for TWSI_STATUS_START / TWSI_STATUS_RPTD_START. MFC after: 3 weeks --- sys/dev/iicbus/twsi/twsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sys/dev/iicbus/twsi/twsi.c b/sys/dev/iicbus/twsi/twsi.c index 4a20d7ea35b6..b94396883be5 100644 --- a/sys/dev/iicbus/twsi/twsi.c +++ b/sys/dev/iicbus/twsi/twsi.c @@ -591,7 +591,6 @@ twsi_intr(void *arg) else TWSI_WRITE(sc, sc->reg_data, sc->msgs[sc->msg_idx].slave & ~LSB); - TWSI_WRITE(sc, sc->reg_control, sc->control_val); break; case TWSI_STATUS_ADDR_W_ACK: