From nobody Wed Nov 24 15:50:23 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 92D6318ADCFE; Wed, 24 Nov 2021 15:50:26 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzlpB2wypz3MgQ; Wed, 24 Nov 2021 15:50:26 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 32C4E2F9A7; Wed, 24 Nov 2021 15:50:26 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id A217B4EC0A; Wed, 24 Nov 2021 16:50:23 +0100 (CET) Date: Wed, 24 Nov 2021 16:50:23 +0100 From: Baptiste Daroussin To: Kyle Evans Cc: "Bjoern A. Zeeb" , src-committers , "" , dev-commits-src-main@freebsd.org Subject: Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD Message-ID: <20211124155023.eqwvw5jamk6vzdxm@aniel.nours.eu> References: <202111241003.1AOA3pxZ008905@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637769026; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LzNCKs0ikLJFw/XoRcOLbtk9pa+kGqvHWl9w8wMdVk4=; b=C/gWoliKn23btsNmP2fZrddloyTK8XtdwbiQ26DRtrCtCx/ajxnpoRvdjUO/X88CW+fNpp cqdRwEisQqFjcQUl0pPnkiQlgZowW0ff/mAE57G49J28KzLo/JhnSNGwxO5Ccov5DuAJ4W 2EQjv279Vcy7b4j0cYyAUeDwoWkYkXAwvZZFBtriUNYVX3VoF5mEnJL7Q790+qdCJkHhnq 6RnWEFVR98ZZ/JKZX7sETpJMhfpwxJTDo6GOJJDNzsmc9rvpem7YcHm5APCoKp/KesAINK /nPPGPsF6bxvrDHb3a+E4HydRIlbhI2fnjbXt9Y1TwYz/yV5V062gk3C+IR9bA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637769026; a=rsa-sha256; cv=none; b=xRt8bNZOwtWIoB3zlrA1Wrw98UD5m0Pe8FCKjHmUxMO2USs7fvGk4BQ0nuA6dj4YeQ5C5/ yr9mfhAwggrld9X1EjCBRSWy44MbIRi66ENe+J0Hh2L3TEFVxvFCW5SRSCSjFtttq7APc7 iPwUoRT5RrOpCyOwnn82CXMdWdkTOEmPRdIMe7rn2uW/K5H1RdI0tQHzYJQ4PskiGmUMqs pNIyqVjhsKO4iXtis4eurLBDUxC4nQjUDyGe2VfOxbsvau+/Aym6hl5/SsBtwgsHvQBUep pS6W/XZ7Fa6pzIBS1Pust9rWlN2PTYVK8mTdUJadOasvSeA9Oa4JJIDKMLb+/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 24, 2021 at 09:43:22AM -0600, Kyle Evans wrote: > On Wed, Nov 24, 2021 at 9:34 AM Bjoern A. Zeeb > wrote: > > > > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > > > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > > > >> On Wed, 24 Nov 2021, Baptiste Daroussin wrote: > > >> > > >>> The branch main has been updated by bapt: > > >>> > > >>> URL: > > >>> https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04 > > >>> > > >>> commit a46722b580567799b484b5a81728eaf380777e04 > > >>> Author: Baptiste Daroussin > > >>> AuthorDate: 2021-11-24 09:20:10 +0000 > > >>> Commit: Baptiste Daroussin > > >>> CommitDate: 2021-11-24 10:02:22 +0000 > > >>> > > >>> ncurses: register formw as usable lib for LIBADD > > >> > > >> is LIBFORM to be LIBFORMW or do we need another new entry? > > >> > > >> 1393 make[7]: "share/mk/bsd.libnames.mk" line 190: lib/ncurses/form: > > >> Missing value for LIBFORMW in bsd.libnames.mk. Likely should be: > > >> LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a > > > > > > > > > and later still: > > > > > > 6315 ld: error: unable to find library -lformw > > > 6316 cc: error: linker command failed with exit code 1 (use -v to see > > > invocation) > > > 6317 --- libprivatebsddialog.so.0.full --- > > > 6318 *** [libprivatebsddialog.so.0.full] Error code 1 > > > > > > > > > @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98 > > > > I've locally fixed this (it seems) like this for now: > > > > diff --git a/Makefile.inc1 b/Makefile.inc1 > > index d8f50cf77d4b..620d9f239b6e 100644 > > --- a/Makefile.inc1 > > +++ b/Makefile.inc1 > > @@ -2943,6 +2943,7 @@ _prebuild_libs= ${_kerberos5_lib_libasn1} \ > > ${_lib_casper} \ > > lib/ncurses/tinfo \ > > lib/ncurses/ncurses \ > > + lib/ncurses/form \ > > lib/libopie lib/libpam/libpam lib/libthr \ > > ${_lib_libradius} lib/libsbuf lib/libtacplus \ > > lib/libgeom \ > > @@ -2982,6 +2983,7 @@ _lib_libradius= lib/libradius > > .endif > > > > lib/ncurses/ncurses__L: lib/ncurses/tinfo__L > > +lib/ncurses/form__L: lib/ncurses/ncurses__L > > > > .if ${MK_OFED} != "no" > > _prebuild_libs+= \ > > > > I would also add a SUBDIR_DEPEND_form in lib/ncurses/Makefile to > reflect this dependency for local builds of lib/ncurses, but > otherwise: > it is already there the SUBDIR_DEPEND Bapt