From nobody Wed Nov 24 15:43:22 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id EBDA218A9CD2; Wed, 24 Nov 2021 15:43:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzlfG4Gbpz3JXX; Wed, 24 Nov 2021 15:43:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 6D6352FF07; Wed, 24 Nov 2021 15:43:34 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f172.google.com with SMTP id 132so3221520qkj.11; Wed, 24 Nov 2021 07:43:34 -0800 (PST) X-Gm-Message-State: AOAM533vl2bXY8eviVdJxrUyRf9w27ZpFR+dAQ37kjLtjffJqmSFvm5S 6NPj+FJNmxfI/Q4oJSCqFCMxfa5jZDso/v8KRZU= X-Google-Smtp-Source: ABdhPJzGi3KYla7p+d8ZJ5sWk9ecM3qA4HHqqel6FxJ5qKCTV4LQFwqtWVuQWM993TlOBMXi+aX/MJd0VubTXqV6J4E= X-Received: by 2002:a05:620a:1a10:: with SMTP id bk16mr7303107qkb.258.1637768613989; Wed, 24 Nov 2021 07:43:33 -0800 (PST) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202111241003.1AOA3pxZ008905@gitrepo.freebsd.org> In-Reply-To: From: Kyle Evans Date: Wed, 24 Nov 2021 09:43:22 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD To: "Bjoern A. Zeeb" Cc: Baptiste Daroussin , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1637768614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LCd4nkhumBHhI8Y4uf4d/RgwsUW+MAW50tQZ2GP0YcE=; b=Lyb8IYU62J9L4VuhcVBmVca+fu+MrRuF5KodK4Q/szR8hHY1XckZrS2q36z/d30RGZC1uf BCW9IkhcdUxOHlxIfQEq6kA+KTvmy6kcoeKgmBOmQVzHmyan6Se9wngNrVStm+n6SDhKpe jMFxU2DldXj9v0wV2p4y2XdLJon/thhjn1DcLLFr2qvKvxFgHGxC1cJzMJlm8Wzxzw4Oag B/VbdSvkdeBynZkWadPX0/X1varDTkgUZ/wI9w/R3+XAPFJny5L7xD3ts9o4jKadNFfaZs 8LuEA7cI//uI82QKxuMj5FQtX+GFCmh+nclHrjCeMpRqYmPSrbtfjngjcwKc4w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1637768614; a=rsa-sha256; cv=none; b=sRP98IR23f0068qPiPnWEUw5M/kkDTedEt+f0eUkGRPAYyaTdiJb6kVRexC4UZccTiC3Zk s7Coiepslv1zq/+4Mg9EqNtSnvbIzzIM39QZZPHx4/SIWreUFt+sZ/0jdx0gUcWLD8FEKa zavqFl1Gtfh2GFcfjPT3IQzb3cWnXC/9VFNZJ3b1paVNoyEjVuju4mr7usD9Hfc8io0c0o d8ic+ryqAyd9gUOAMLYcsjeDsKhdWprAES29OiWjfL+OCP2g0YHL9pzm6DVRxQynVEMz/c Q0iN8ORB3138yMA5TPl5Z78zMS2TLeXYhv2PWoxYcAyFK3kgt+/kxBLF8rfhzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N On Wed, Nov 24, 2021 at 9:34 AM Bjoern A. Zeeb wrote: > > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > > > >> On Wed, 24 Nov 2021, Baptiste Daroussin wrote: > >> > >>> The branch main has been updated by bapt: > >>> > >>> URL: > >>> https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04 > >>> > >>> commit a46722b580567799b484b5a81728eaf380777e04 > >>> Author: Baptiste Daroussin > >>> AuthorDate: 2021-11-24 09:20:10 +0000 > >>> Commit: Baptiste Daroussin > >>> CommitDate: 2021-11-24 10:02:22 +0000 > >>> > >>> ncurses: register formw as usable lib for LIBADD > >> > >> is LIBFORM to be LIBFORMW or do we need another new entry? > >> > >> 1393 make[7]: "share/mk/bsd.libnames.mk" line 190: lib/ncurses/form: > >> Missing value for LIBFORMW in bsd.libnames.mk. Likely should be: > >> LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a > > > > > > and later still: > > > > 6315 ld: error: unable to find library -lformw > > 6316 cc: error: linker command failed with exit code 1 (use -v to see > > invocation) > > 6317 --- libprivatebsddialog.so.0.full --- > > 6318 *** [libprivatebsddialog.so.0.full] Error code 1 > > > > > > @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98 > > I've locally fixed this (it seems) like this for now: > > diff --git a/Makefile.inc1 b/Makefile.inc1 > index d8f50cf77d4b..620d9f239b6e 100644 > --- a/Makefile.inc1 > +++ b/Makefile.inc1 > @@ -2943,6 +2943,7 @@ _prebuild_libs= ${_kerberos5_lib_libasn1} \ > ${_lib_casper} \ > lib/ncurses/tinfo \ > lib/ncurses/ncurses \ > + lib/ncurses/form \ > lib/libopie lib/libpam/libpam lib/libthr \ > ${_lib_libradius} lib/libsbuf lib/libtacplus \ > lib/libgeom \ > @@ -2982,6 +2983,7 @@ _lib_libradius= lib/libradius > .endif > > lib/ncurses/ncurses__L: lib/ncurses/tinfo__L > +lib/ncurses/form__L: lib/ncurses/ncurses__L > > .if ${MK_OFED} != "no" > _prebuild_libs+= \ > I would also add a SUBDIR_DEPEND_form in lib/ncurses/Makefile to reflect this dependency for local builds of lib/ncurses, but otherwise: Reviewed by: Kyle Evans