From nobody Wed Nov 24 15:34:02 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id ACFA118A54DB; Wed, 24 Nov 2021 15:34:08 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mx1.sbone.de (mx1.sbone.de [IPv6:2a01:4f8:13b:39f::9f:25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mx1.sbone.de", Issuer "SBone.DE" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HzlRM2xYfz3FD6; Wed, 24 Nov 2021 15:34:07 +0000 (UTC) (envelope-from bzeeb-lists@lists.zabbadoz.net) Received: from mail.sbone.de (mail.sbone.de [IPv6:fde9:577b:c1a9:31::2013:587]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.sbone.de (Postfix) with ESMTPS id 6EE358D4A212; Wed, 24 Nov 2021 15:34:05 +0000 (UTC) Received: from content-filter.sbone.de (content-filter.sbone.de [IPv6:fde9:577b:c1a9:31::2013:2742]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPS id DE13DE70847; Wed, 24 Nov 2021 15:34:04 +0000 (UTC) X-Virus-Scanned: amavisd-new at sbone.de Received: from mail.sbone.de ([IPv6:fde9:577b:c1a9:31::2013:587]) by content-filter.sbone.de (content-filter.sbone.de [fde9:577b:c1a9:31::2013:2742]) (amavisd-new, port 10024) with ESMTP id 5QCXisw6sBDg; Wed, 24 Nov 2021 15:34:03 +0000 (UTC) Received: from nv.sbone.de (nv.sbone.de [IPv6:fde9:577b:c1a9:31::2013:138]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.sbone.de (Postfix) with ESMTPSA id 1DD59E70846; Wed, 24 Nov 2021 15:34:03 +0000 (UTC) Date: Wed, 24 Nov 2021 15:34:02 +0000 (UTC) From: "Bjoern A. Zeeb" To: Baptiste Daroussin cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: a46722b58056 - main - ncurses: register formw as usable lib for LIBADD In-Reply-To: Message-ID: References: <202111241003.1AOA3pxZ008905@gitrepo.freebsd.org> X-OpenPGP-Key-Id: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: 4HzlRM2xYfz3FD6 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of bzeeb-lists@lists.zabbadoz.net designates 2a01:4f8:13b:39f::9f:25 as permitted sender) smtp.mailfrom=bzeeb-lists@lists.zabbadoz.net X-Spamd-Result: default: False [-2.90 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; NEURAL_HAM_MEDIUM(-0.63)[-0.633]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; R_SPF_ALLOW(-0.20)[+ip6:2a01:4f8:13b:39f::9f:25]; DMARC_NA(0.00)[zabbadoz.net]; NEURAL_HAM_LONG(-0.98)[-0.981]; NEURAL_HAM_SHORT(-0.99)[-0.991]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/32, country:DE]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > On Wed, 24 Nov 2021, Bjoern A. Zeeb wrote: > >> On Wed, 24 Nov 2021, Baptiste Daroussin wrote: >> >>> The branch main has been updated by bapt: >>> >>> URL: >>> https://cgit.FreeBSD.org/src/commit/?id=a46722b580567799b484b5a81728eaf380777e04 >>> >>> commit a46722b580567799b484b5a81728eaf380777e04 >>> Author: Baptiste Daroussin >>> AuthorDate: 2021-11-24 09:20:10 +0000 >>> Commit: Baptiste Daroussin >>> CommitDate: 2021-11-24 10:02:22 +0000 >>> >>> ncurses: register formw as usable lib for LIBADD >> >> is LIBFORM to be LIBFORMW or do we need another new entry? >> >> 1393 make[7]: "share/mk/bsd.libnames.mk" line 190: lib/ncurses/form: >> Missing value for LIBFORMW in bsd.libnames.mk. Likely should be: >> LIBFORMW?= ${LIBDESTDIR}${LIBDIR_BASE}/libformw.a > > > and later still: > > 6315 ld: error: unable to find library -lformw > 6316 cc: error: linker command failed with exit code 1 (use -v to see > invocation) > 6317 --- libprivatebsddialog.so.0.full --- > 6318 *** [libprivatebsddialog.so.0.full] Error code 1 > > > @ 848ee2a3a8b47c9905fc51fefcf60eb371edbb98 I've locally fixed this (it seems) like this for now: diff --git a/Makefile.inc1 b/Makefile.inc1 index d8f50cf77d4b..620d9f239b6e 100644 --- a/Makefile.inc1 +++ b/Makefile.inc1 @@ -2943,6 +2943,7 @@ _prebuild_libs= ${_kerberos5_lib_libasn1} \ ${_lib_casper} \ lib/ncurses/tinfo \ lib/ncurses/ncurses \ + lib/ncurses/form \ lib/libopie lib/libpam/libpam lib/libthr \ ${_lib_libradius} lib/libsbuf lib/libtacplus \ lib/libgeom \ @@ -2982,6 +2983,7 @@ _lib_libradius= lib/libradius .endif lib/ncurses/ncurses__L: lib/ncurses/tinfo__L +lib/ncurses/form__L: lib/ncurses/ncurses__L .if ${MK_OFED} != "no" _prebuild_libs+= \ -- Bjoern A. Zeeb r15:7