From nobody Tue Nov 23 08:09:08 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 12887188F33B; Tue, 23 Nov 2021 08:09:32 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from vtr.rulingia.com (vtr.rulingia.com [IPv6:2001:19f0:5801:ebe:5400:1ff:fe53:30fd]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "vtr.rulingia.com", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hyxcq0QPQz4Xmc; Tue, 23 Nov 2021 08:09:30 +0000 (UTC) (envelope-from peter@rulingia.com) Received: from server.rulingia.com (2001-44b8-31fc-0d00-31f0-2684-db50-01b3.static.ipv6.internode.on.net [IPv6:2001:44b8:31fc:d00:31f0:2684:db50:1b3]) by vtr.rulingia.com (8.16.1/8.16.1) with ESMTPS id 1AN89EPw021546 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 23 Nov 2021 19:09:20 +1100 (AEDT) (envelope-from peter@rulingia.com) DKIM-Filter: OpenDKIM Filter v2.10.3 vtr.rulingia.com 1AN89EPw021546 X-Bogosity: Ham, spamicity=0.000000 Received: from server.rulingia.com (localhost.rulingia.com [127.0.0.1]) by server.rulingia.com (8.16.1/8.16.1) with ESMTPS id 1AN898eE086750 (version=TLSv1.3 cipher=AEAD-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 23 Nov 2021 19:09:08 +1100 (AEDT) (envelope-from peter@server.rulingia.com) Received: (from peter@localhost) by server.rulingia.com (8.16.1/8.16.1/Submit) id 1AN898p6086749; Tue, 23 Nov 2021 19:09:08 +1100 (AEDT) (envelope-from peter) Date: Tue, 23 Nov 2021 19:09:08 +1100 From: Peter Jeremy To: Konstantin Belousov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 8ef0c11e7ce7 - main - nfsclient: upgrade vnode lock in VOP_OPEN()/VOP_CLOSE() if we need to flush buffers Message-ID: References: <202111161714.1AGHEtBA084291@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Hxj8mYM555kBddIP" Content-Disposition: inline In-Reply-To: <202111161714.1AGHEtBA084291@gitrepo.freebsd.org> X-PGP-Key: http://www.rulingia.com/keys/peter.pgp X-Rspamd-Queue-Id: 4Hyxcq0QPQz4Xmc X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=quarantine) header.from=rulingia.com; spf=pass (mx1.freebsd.org: domain of peter@rulingia.com designates 2001:19f0:5801:ebe:5400:1ff:fe53:30fd as permitted sender) smtp.mailfrom=peter@rulingia.com X-Spamd-Result: default: False [-5.90 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FREEFALL_USER(0.00)[peter]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; R_SPF_ALLOW(-0.20)[+mx]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; MID_RHS_MATCH_FROMTLD(0.00)[]; NEURAL_HAM_SHORT(-1.00)[-1.000]; DMARC_POLICY_ALLOW(-0.50)[rulingia.com,quarantine]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:20473, ipnet:2001:19f0:5800::/38, country:US]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --Hxj8mYM555kBddIP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Nov-16 17:14:55 +0000, Konstantin Belousov wrote: > nfsclient: upgrade vnode lock in VOP_OPEN()/VOP_CLOSE() if we need to = flush buffers > =20 > VOP_FSYNC() asserts that the vnode is exclusively locked for NFS. > If we try to execute file with recently modified content, the assert is > triggered. I have a diskless arm64 system configured with swap over NFS and I'm now consistently getting a panic during shutdown. I haven't specificially confirmed that it's this commit but the content is suggestive. panic: upgrade of unlocked lock (lockmgr) nfs @ /usr/src/sys/fs/nfsclient/n= fs_clvnops.c:855 cpuid =3D 3 time =3D 1637166551 KDB: stack backtrace: db_trace_self() at db_trace_self db_trace_self_wrapper() at db_trace_self_wrapper+0x30 vpanic() at vpanic+0x178 panic() at panic+0x44 witness_upgrade() at witness_upgrade+0x104 lockmgr_upgrade() at lockmgr_upgrade+0x164 nfs_lock() at nfs_lock+0x2c vop_sigdefer() at vop_sigdefer+0x30 _vn_lock() at _vn_lock+0x54 nfs_close() at nfs_close+0xc8 vop_sigdefer() at vop_sigdefer+0x30 VOP_CLOSE_APV() at VOP_CLOSE_APV+0x2c swapdev_close() at swapdev_close+0x3c swapoff_one() at swapoff_one+0x598 sys_swapoff() at sys_swapoff+0x12c do_el0_sync() at do_el0_sync+0x498 handle_el0_sync() at handle_el0_sync+0x90 --- exception, esr 0x56000000 I presume this isn't intended. Can you suggest where I should start looking for the problem? --=20 Peter Jeremy --Hxj8mYM555kBddIP Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmGcoZtfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzShqg//RQMm2oSJsE4VwdVkwuhN7uYCCOF4qJPYpgBsEBkVctXPVBfs1HZ04t4k SC7DRyuqT1I2DHAKbfM/ryKft+4pbPTgcZnvoDxZJ/DMPmx54FIfckm4zuRy1Uhx urxsUWAAD+H0NnXG3ipOZIF1alEROiRqOv3UnOy44vqXSEELsvBeetdFL/QrQ2RB Fm5WK4MxVNF6cdlpCB2/9x3F5Wy+oIsN7+RzVGa01vXD03XxNsx8vGPzTiGwUuqL W2I06iJMa4HodZS/7otMJmW8cTRhI2eOHJ2e2bbXlfTl6EuymvOZUDnyHUznYiDE VIbH4foIqb7I7EOykciSfDl4aAh3PBoBtYj0q3UCojk/FkSa+0kAKP0iCrdZgKpn mC5LijOx9j14QkELMHE+hVviZUdW+EavCa3phx5S7iWvApYkYWgIBA5nJb2pGOZN aZM0eRIMd9xVkP62nt5hxGkqepkAjAWux+JjscIrZ9f9aNSVKHfKBU40TpRgli3J vg2h1mnWzg3jOQr2lggRBITKwID8IgNDGPR4T9mbfXL+uvPXrJ5LG9p9qdLkis1Z /56PZWkJHOqmOac9VB6fKgXH2OFDAitcwTtxQJXKFHNxC8SGyIuwo2r/kxWvsimn 8pYBjZAWGxspf/IypyOBbWAUWuTEh7TxCUiaaWi52Z/WYlA/Ylw= =4qID -----END PGP SIGNATURE----- --Hxj8mYM555kBddIP--