From nobody Mon Nov 22 16:38:33 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 6DA17188BDBB; Mon, 22 Nov 2021 16:38:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HyXyh2m5vz3mrs; Mon, 22 Nov 2021 16:38:36 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from [IPV6:2601:648:8601:8b20:7de4:e77a:791:6f5] (unknown [IPv6:2601:648:8601:8b20:7de4:e77a:791:6f5]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id BCDD98AFE; Mon, 22 Nov 2021 16:38:35 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <428e410d-33c1-7ff8-9689-41943db3d9c3@FreeBSD.org> Date: Mon, 22 Nov 2021 08:38:33 -0800 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: git: 2eb2079554f4 - main - bhyve: keep physical and virtual COMMAND reg in sync Content-Language: en-US To: Emmanuel Vadot , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202111221530.1AMFUUJn079855@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202111221530.1AMFUUJn079855@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ThisMailContainsUnwantedMimeParts: N On 11/22/21 7:30 AM, Emmanuel Vadot wrote: > The branch main has been updated by manu: > > URL: https://cgit.FreeBSD.org/src/commit/?id=2eb2079554f4d54c4283410b4ee1aca549b29616 > > commit 2eb2079554f4d54c4283410b4ee1aca549b29616 > Author: Corvin Köhne > AuthorDate: 2021-11-22 15:26:03 +0000 > Commit: Emmanuel Vadot > CommitDate: 2021-11-22 15:26:03 +0000 > > bhyve: keep physical and virtual COMMAND reg in sync > > On startup all virtual BARs are registered. > Additionally, the encoding bit in the virtual cmd register is set. > After that, the passthru emulation overwrites the virtual cmd register with > the physical one. > This could lead to a mismatch between registered BARs and the encoding > bits in the cmd register. > Instead of writing the physical to the virtual cmd register, > write the virtual to the physical cmd register to solve this issue. > > Reviewed by: markj > Differential Revision: https://reviews.freebsd.org/D32687 > Sponsored by: Beckhoff Automation GmbH & Co. KG Humm, I wonder if my older patch that tries to handle the command register more deterministically might have handled this. The patch tried to fix an open bug where you can't use a XHCI controller via passthru after you have rebooted a Linux guest. It makes this write here conditional: https://reviews.freebsd.org/D20623 -- John Baldwin