From nobody Fri Nov 19 17:49:21 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 17DB6189A032; Fri, 19 Nov 2021 17:49:30 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Hwkgs6PTxz3DcW; Fri, 19 Nov 2021 17:49:29 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by mail-qk1-x72b.google.com with SMTP id m192so6550415qke.2; Fri, 19 Nov 2021 09:49:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fH3oXgEA26koOZzUS7kaM14UjQdnbcbUXB9k1uP96n4=; b=RZHFrbL3BHuPgxhdAMjuScodpLgViLHqlzirq0k+iXoV/0Rg9RvC+50O/tF8/aymCT AUgyGMd8NCn94FvtclbHQbyFa25/G7HUfg3P434De4aT+uCM2AQi1NAOqqn1+56VlMOs pTAIBTmkCOrkhrDT28rbvLAaRW8QoRN7JSJ3OqLj4RgijaKm+DoUH1SnAtGVLQSZr9K3 SivCJVzfHYKhaNfKRoPjty8XVtOylt2Bn4jN9DQ+UgRJ3Su+4FD8KiabmfhE0GI92R1Z Vavsu7cugOv9EEMpKTIFhgMwgETGawoh+p5qhL58r0fPZ6wDMdde1IoYJ++V7ab0iD6E WbRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fH3oXgEA26koOZzUS7kaM14UjQdnbcbUXB9k1uP96n4=; b=GPWBcK2nkgTcCf4SoRC/err2M35VLpBVKP5nFxtcdIKzd2wBewlA0Fqb/bWMAu/dD9 p5m7XpZevY/P1/h/5SI4dEWx+fMNH9+YA55mN7k5KJi0I4Yb+XkaUtyT8LA97LvXOESY vgC6/BLne0cqiW/xevAK/op+0t/lemzLnoqneNi0IKx14fu0ovCaH780TYHgq7aeHMY0 qlUHhoM/s/+93/okkJU1YuvIRsxQDRz1xmaze9XHmoES09lrRbb0TSGfeze4UhZIenpp heRY8AD8pFytJqUm39SbPY7dSLJgjBbC5qwrwr9FY/bfcTYWJU2wTTeuNCJ3myX3JpGS 3nIQ== X-Gm-Message-State: AOAM5319x/ZXZSdNCmz3QeyskElLzx0Iz/zm3j/7fn52i/R8cpDw+W6R t3ZVms+T7c6ntNkool0QxPPZAjeYr44= X-Google-Smtp-Source: ABdhPJzJRaCCh3lyGr73o+TqS16udcHLkBmd9lBGxwWTFSklvr/WqIj2T8lv4ANlwL8z+oVxcuoXpA== X-Received: by 2002:a05:620a:461e:: with SMTP id br30mr29952912qkb.363.1637344162693; Fri, 19 Nov 2021 09:49:22 -0800 (PST) Received: from spectre.mavhome.dp.ua (104-55-12-234.lightspeed.knvltn.sbcglobal.net. [104.55.12.234]) by smtp.gmail.com with ESMTPSA id e13sm253672qte.56.2021.11.19.09.49.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Nov 2021 09:49:22 -0800 (PST) Subject: Re: git: 9cb485d18f01 - main - geom: Remove g_class.config To: Warner Losh Cc: Warner Losh , src-committers , dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202111190620.1AJ6KS08078314@gitrepo.freebsd.org> <708f1f87-0082-5259-24df-cf23b87b628f@gmail.com> From: Alexander Motin Message-ID: <66dd682b-6341-5036-4ccf-00af5c960d41@gmail.com> Date: Fri, 19 Nov 2021 12:49:21 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4Hwkgs6PTxz3DcW X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N You are right, but I'd generally try to preserve KBI even in current, when possible, to ease upgrades. On 19.11.2021 11:46, Warner Losh wrote: > Thanks Alexander...  I understand this comment for MFCing, but -current > isn't KBI > stable, though I likely should have bumped FreeBSD_version to cope > instead. Am I > missing something? > > Warner > > On Fri, Nov 19, 2021 at 8:05 AM Alexander Motin > wrote: > > I have no objections, but I'd leave padding there to not break KBI for > out of tree GEOM classes. > > On 19.11.2021 01:20, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=9cb485d18f01900800efe4ec3cfcfadd335da858 > > > > > commit 9cb485d18f01900800efe4ec3cfcfadd335da858 > > Author:     Wuyang Chung > > > AuthorDate: 2021-10-16 01:43:54 +0000 > > Commit:     Warner Losh > > CommitDate: 2021-11-19 06:17:07 +0000 > > > >     geom: Remove g_class.config > >      > >     g_class.config is write only, remove it. > > --- > >  sys/geom/geom.h      | 1 - > >  sys/geom/geom_subr.c | 1 - > >  2 files changed, 2 deletions(-) > > > > diff --git a/sys/geom/geom.h b/sys/geom/geom.h > > index 1aba1f46d6d5..0d6d74d0b51c 100644 > > --- a/sys/geom/geom.h > > +++ b/sys/geom/geom.h > > @@ -96,7 +96,6 @@ struct g_class { > >       u_int                   version; > >       u_int                   spare0; > >       g_taste_t               *taste; > > -     g_config_t              *config; > >       g_ctl_req_t             *ctlreq; > >       g_init_t                *init; > >       g_fini_t                *fini; > > diff --git a/sys/geom/geom_subr.c b/sys/geom/geom_subr.c > > index 2f7ea7754f7b..abaae5ccf57f 100644 > > --- a/sys/geom/geom_subr.c > > +++ b/sys/geom/geom_subr.c > > @@ -222,7 +222,6 @@ retry: > >  > >       /* Bar new entries */ > >       mp->taste = NULL; > > -     mp->config = NULL; > >  > >       LIST_FOREACH(gp, &mp->geom, geom) { > >               error = mp->destroy_geom(NULL, mp, gp); > > > > -- > Alexander Motin > -- Alexander Motin