git: defbe7a7ca21 - stable/13 - ffs: Remove assertions about locked um_devvp in several places
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 19 Nov 2021 04:36:45 UTC
The branch stable/13 has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=defbe7a7ca212fd93fc367f0d02ffa340635c4c4
commit defbe7a7ca212fd93fc367f0d02ffa340635c4c4
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-11-01 08:04:27 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-11-19 04:25:28 +0000
ffs: Remove assertions about locked um_devvp in several places
(cherry picked from commit 76b05e3e399133b59fc3e740cab9ae362358c9d6)
---
sys/ufs/ffs/ffs_alloc.c | 7 +++++--
sys/ufs/ffs/ffs_vfsops.c | 2 +-
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/sys/ufs/ffs/ffs_alloc.c b/sys/ufs/ffs/ffs_alloc.c
index 6a262a798d1b..42708e3dce71 100644
--- a/sys/ufs/ffs/ffs_alloc.c
+++ b/sys/ufs/ffs/ffs_alloc.c
@@ -2251,9 +2251,12 @@ ffs_blkfree_cg(ump, fs, devvp, bno, size, inum, dephd)
MPASS(devvp->v_mount->mnt_data == ump);
dev = ump->um_devvp->v_rdev;
} else if (devvp->v_type == VCHR) {
- /* devvp is a normal disk device */
+ /*
+ * devvp is a normal disk device
+ * XXXKIB: devvp is not locked there, v_rdev access depends on
+ * busy mount, which prevents mntfs devvp from reclamation.
+ */
dev = devvp->v_rdev;
- ASSERT_VOP_LOCKED(devvp, "ffs_blkfree_cg");
} else
return;
#ifdef INVARIANTS
diff --git a/sys/ufs/ffs/ffs_vfsops.c b/sys/ufs/ffs/ffs_vfsops.c
index 0b96edff12ff..b8f7c3821bf7 100644
--- a/sys/ufs/ffs/ffs_vfsops.c
+++ b/sys/ufs/ffs/ffs_vfsops.c
@@ -1544,7 +1544,7 @@ ffs_flushfiles(mp, flags, td)
*/
}
#endif
- ASSERT_VOP_LOCKED(ump->um_devvp, "ffs_flushfiles");
+ /* devvp is not locked there */
if (ump->um_devvp->v_vflag & VV_COPYONWRITE) {
if ((error = vflush(mp, 0, SKIPSYSTEM | flags, td)) != 0)
return (error);