git: a7e4eb142298 - main - Kernel linkers: some style
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 18 Nov 2021 13:57:02 UTC
The branch main has been updated by kib:
URL: https://cgit.FreeBSD.org/src/commit/?id=a7e4eb14229845c0857caf91bc3364f9e7075b00
commit a7e4eb14229845c0857caf91bc3364f9e7075b00
Author: Konstantin Belousov <kib@FreeBSD.org>
AuthorDate: 2021-11-07 09:03:45 +0000
Commit: Konstantin Belousov <kib@FreeBSD.org>
CommitDate: 2021-11-18 13:56:23 +0000
Kernel linkers: some style
Reviewed by: emaste
Sponsored by: The FreeBSD Foundation
MFC after: 3 days
Differential revision: https://reviews.freebsd.org/D32878
---
sys/kern/link_elf.c | 10 +++++-----
sys/kern/link_elf_obj.c | 36 ++++++++++++++++--------------------
2 files changed, 21 insertions(+), 25 deletions(-)
diff --git a/sys/kern/link_elf.c b/sys/kern/link_elf.c
index 2faaa003380a..4114bd46f0c0 100644
--- a/sys/kern/link_elf.c
+++ b/sys/kern/link_elf.c
@@ -1596,12 +1596,12 @@ static int
link_elf_search_symbol(linker_file_t lf, caddr_t value,
c_linker_sym_t *sym, long *diffp)
{
- elf_file_t ef = (elf_file_t) lf;
- u_long off = (uintptr_t) (void *) value;
+ elf_file_t ef = (elf_file_t)lf;
+ u_long off = (uintptr_t) (void *)value;
u_long diff = off;
u_long st_value;
- const Elf_Sym* es;
- const Elf_Sym* best = NULL;
+ const Elf_Sym *es;
+ const Elf_Sym *best = NULL;
int i;
for (i = 0, es = ef->ddbsymtab; i < ef->ddbsymcnt; i++, es++) {
@@ -1711,7 +1711,7 @@ link_elf_each_function_nameval(linker_file_t file,
{
linker_symval_t symval;
elf_file_t ef = (elf_file_t)file;
- const Elf_Sym* symp;
+ const Elf_Sym *symp;
int i, error;
/* Exhaustive search */
diff --git a/sys/kern/link_elf_obj.c b/sys/kern/link_elf_obj.c
index 91852939e5e8..5c6db11e1937 100644
--- a/sys/kern/link_elf_obj.c
+++ b/sys/kern/link_elf_obj.c
@@ -1421,7 +1421,7 @@ link_elf_lookup_symbol(linker_file_t lf, const char *name, c_linker_sym_t *sym)
return 0;
}
}
- return ENOENT;
+ return (ENOENT);
}
static int
@@ -1442,17 +1442,17 @@ link_elf_symbol_values(linker_file_t lf, c_linker_sym_t sym,
val = ((caddr_t (*)(void))val)();
symval->value = val;
symval->size = es->st_size;
- return 0;
+ return (0);
}
- return ENOENT;
+ return (ENOENT);
}
static int
link_elf_search_symbol(linker_file_t lf, caddr_t value,
c_linker_sym_t *sym, long *diffp)
{
- elf_file_t ef = (elf_file_t) lf;
- u_long off = (uintptr_t) (void *) value;
+ elf_file_t ef = (elf_file_t)lf;
+ u_long off = (uintptr_t)(void *)value;
u_long diff = off;
u_long st_value;
const Elf_Sym *es;
@@ -1480,7 +1480,7 @@ link_elf_search_symbol(linker_file_t lf, caddr_t value,
*diffp = diff;
*sym = (c_linker_sym_t) best;
- return 0;
+ return (0);
}
/*
@@ -1779,25 +1779,21 @@ link_elf_reloc_local(linker_file_t lf, bool ifuncs)
static long
link_elf_symtab_get(linker_file_t lf, const Elf_Sym **symtab)
{
- elf_file_t ef = (elf_file_t)lf;
-
- *symtab = ef->ddbsymtab;
-
- if (*symtab == NULL)
- return (0);
+ elf_file_t ef = (elf_file_t)lf;
- return (ef->ddbsymcnt);
+ *symtab = ef->ddbsymtab;
+ if (*symtab == NULL)
+ return (0);
+ return (ef->ddbsymcnt);
}
static long
link_elf_strtab_get(linker_file_t lf, caddr_t *strtab)
{
- elf_file_t ef = (elf_file_t)lf;
-
- *strtab = ef->ddbstrtab;
-
- if (*strtab == NULL)
- return (0);
+ elf_file_t ef = (elf_file_t)lf;
- return (ef->ddbstrcnt);
+ *strtab = ef->ddbstrtab;
+ if (*strtab == NULL)
+ return (0);
+ return (ef->ddbstrcnt);
}