From nobody Tue Nov 16 14:00:45 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D8BA8189075F; Tue, 16 Nov 2021 14:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HtnlK5cW5z4nw2; Tue, 16 Nov 2021 14:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id A27376831; Tue, 16 Nov 2021 14:00:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1AGE0jDC026358; Tue, 16 Nov 2021 14:00:45 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1AGE0jZ3026357; Tue, 16 Nov 2021 14:00:45 GMT (envelope-from git) Date: Tue, 16 Nov 2021 14:00:45 GMT Message-Id: <202111161400.1AGE0jZ3026357@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "George V. Neville-Neil" Subject: git: 409d1bf7d6de - main - Address review comments from 0mp, debdrup and oshogbo List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: gnn X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 409d1bf7d6deef77ccf685e1624589997247a267 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by gnn: URL: https://cgit.FreeBSD.org/src/commit/?id=409d1bf7d6deef77ccf685e1624589997247a267 commit 409d1bf7d6deef77ccf685e1624589997247a267 Author: George V. Neville-Neil AuthorDate: 2021-11-10 13:18:32 +0000 Commit: George V. Neville-Neil CommitDate: 2021-11-10 18:09:18 +0000 Address review comments from 0mp, debdrup and oshogbo --- lib/libcasper/libcasper/libcasper.3 | 19 ++++++++++--------- lib/libcasper/libcasper/libcasper_service.3 | 14 +++++++------- lib/libcasper/services/cap_net/cap_net.3 | 2 +- 3 files changed, 18 insertions(+), 17 deletions(-) diff --git a/lib/libcasper/libcasper/libcasper.3 b/lib/libcasper/libcasper/libcasper.3 index c08ea0f21f8b..02c08270dcf2 100644 --- a/lib/libcasper/libcasper/libcasper.3 +++ b/lib/libcasper/libcasper/libcasper.3 @@ -28,7 +28,7 @@ .\" .\" $FreeBSD$ .\" -.Dd January 3, 2021 +.Dd November 15, 2021 .Dt LIBCASPER 3 .Os .Sh NAME @@ -78,7 +78,8 @@ .Sh DESCRIPTION The .Nm libcasper -library provides for the control of application capabilities through the casper process. +library provides for the control of application capabilities through +the casper process. .Pp An application capability, represented by the .Vt cap_channel_t @@ -86,7 +87,7 @@ type, is a communication channel between the caller and the casper daemon or an instance of one of the daemon's services. A capability to the casper process, obtained with the .Fn cap_init -function, allows a program to create capabilities to acacce +function, allows a program to create capabilities to access the casper daemon's services via the .Fn cap_service_open function. @@ -107,7 +108,7 @@ system call, or sent over a .Xr unix 4 domain socket as a file descriptor, -nd has to be converted into a +and has to be converted into a .Vt cap_channel_t . The .Fa flags @@ -115,16 +116,15 @@ argument defines the channel behavior. The supported flags are: .Bl -ohang -offset indent .It CASPER_NO_UNIQ -The communication between the process and the casper daemon no unique version of nvlist. +The communication between the process and the casper daemon no +unique version of nvlist. .El .Pp The .Fn cap_unwrap function returns the .Xr unix 4 -domain socket that was provided to the -.Fn cap_wrap -function, +domain socket used by the daemon service, and frees the .Vt cap_channel_t structure. @@ -191,7 +191,8 @@ The .Fn cap_xfer_nvlist function sends the given .Xr nvlist 9 , -destroys it, and receives a new +destroys it, +and receives a new .Xr nvlist 9 in response over the given capability. It does not matter if the function succeeds or fails, the diff --git a/lib/libcasper/libcasper/libcasper_service.3 b/lib/libcasper/libcasper/libcasper_service.3 index c210cdde182a..9e0f76cf98d0 100644 --- a/lib/libcasper/libcasper/libcasper_service.3 +++ b/lib/libcasper/libcasper/libcasper_service.3 @@ -24,7 +24,7 @@ .\" .\" $FreeBSD$ .\" -.Dd May 5, 2020 +.Dd November 15, 2021 .Dt LIBCASPER 3 .Os .Sh NAME @@ -47,7 +47,7 @@ typedef int service_command_func_t(const char *, const nvlist_t *, nvlist_t *, .Sh DESCRIPTION The .Nm CREATE_SERVICE -macro is used to create a new Casper service. +macro is used to create a new casper service. The .Fa name is a string containing the service name, which will be used in the @@ -61,7 +61,7 @@ is a function of type where the first argument of the function contains an containing .Xr nvlist 9 , old service limits and the second argument contains the new limits. -If the service wasn't limited then the old limits will be set to +If the service was not limited then the old limits will be set to .Dv NULL . This function must not allow the extension of service limits. The @@ -76,7 +76,7 @@ contains the current limits and the second contains an with the current request. The last argument contains a return value .Xr nvlist 9 -which contains the response from Casper. +which contains the response from casper. .Pp The .Fa flags @@ -84,14 +84,14 @@ argument defines the limits of the service. The supported flags are: .Bl -ohang -offset indent .It CASPER_SERVICE_STDIO -The Casper service has access to the stdio descriptors from the process it was +The casper service has access to the stdio descriptors from the process it was spawned from. .It CASPER_SERVICE_FD -The Casper service has access to all of the descriptors, +The casper service has access to all of the descriptors, besides the stdio descriptors, from the process it was spawned from. .It CASPER_SERVICE_NO_UNIQ_LIMITS -The whole Casper communication is using an +The whole casper communication is using an .Xr nvlist 9 with the .Xr NVLIST_NO_UNIQ 9 diff --git a/lib/libcasper/services/cap_net/cap_net.3 b/lib/libcasper/services/cap_net/cap_net.3 index 765abbdf41aa..e64038a48330 100644 --- a/lib/libcasper/services/cap_net/cap_net.3 +++ b/lib/libcasper/services/cap_net/cap_net.3 @@ -23,7 +23,7 @@ .\" .\" $FreeBSD$ .\" -.Dd August 15, 2020 +.Dd November 15, 2021 .Dt CAP_NET 3 .Os .Sh NAME