git: 64acb29b7d96 - main - sockstat: change check for wildcard sockets to avoid historical classes
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 Nov 2021 15:36:08 UTC
The branch main has been updated by karels:
URL: https://cgit.FreeBSD.org/src/commit/?id=64acb29b7d9699c301a55a5431d94374391e4f30
commit 64acb29b7d9699c301a55a5431d94374391e4f30
Author: Mike Karels <karels@FreeBSD.org>
AuthorDate: 2021-10-27 03:12:24 +0000
Commit: Mike Karels <karels@FreeBSD.org>
CommitDate: 2021-11-09 15:34:44 +0000
sockstat: change check for wildcard sockets to avoid historical classes
sockstat was checking whether a bound address was "host 0", the lowest
host on a network, using inet_lnaof(). This only works for class A/B/C.
However, it isn't useful to bind such an address unless it is really
the unspecified address INADDR_ANY. Change the check to to use that.
MFC after: 1 month
Reviewd by: tuexen
Differential Revision: https://reviews.freebsd.org/D32715
---
usr.bin/sockstat/sockstat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/usr.bin/sockstat/sockstat.c b/usr.bin/sockstat/sockstat.c
index d7fdb87b7490..1a4413116a79 100644
--- a/usr.bin/sockstat/sockstat.c
+++ b/usr.bin/sockstat/sockstat.c
@@ -874,7 +874,7 @@ printaddr(struct sockaddr_storage *ss)
switch (ss->ss_family) {
case AF_INET:
- if (inet_lnaof(sstosin(ss)->sin_addr) == INADDR_ANY)
+ if (sstosin(ss)->sin_addr.s_addr == INADDR_ANY)
addrstr[0] = '*';
port = ntohs(sstosin(ss)->sin_port);
break;