git: 477aeb3dd479 - main - tcp: Printf should be removed.

From: Randall Stewart <rrs_at_FreeBSD.org>
Date: Mon, 08 Nov 2021 16:51:41 UTC
The branch main has been updated by rrs:

URL: https://cgit.FreeBSD.org/src/commit/?id=477aeb3dd47944fee14a2ffd8573f99e2a7af696

commit 477aeb3dd47944fee14a2ffd8573f99e2a7af696
Author:     Randall Stewart <rrs@FreeBSD.org>
AuthorDate: 2021-11-08 16:49:34 +0000
Commit:     Randall Stewart <rrs@FreeBSD.org>
CommitDate: 2021-11-08 16:49:34 +0000

    tcp: Printf should be removed.
    
    There is a printf when a socket option down to the CC module fails, this really
    should not be a printf. In fact this whole option needs to be re-thought in coordination
    with some other changes in the CC modules (its just not right but its ok what it
    does here if it fails since it will just use the ECN beta).
    
    Reviewed by: Michael Tuexen
    Sponsored by: Netflix Inc.
    Differential Revision: https://reviews.freebsd.org/D32894
---
 sys/netinet/tcp_stacks/rack.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c
index 3d065ef14c86..b1927f0a17e4 100644
--- a/sys/netinet/tcp_stacks/rack.c
+++ b/sys/netinet/tcp_stacks/rack.c
@@ -599,7 +599,6 @@ rack_set_cc_pacing(struct tcp_rack *rack)
 	ptr = ((struct newreno *)tp->ccv->cc_data);
 	if (CC_ALGO(tp)->ctl_output == NULL)  {
 		/* Huh, why does new_reno no longer have a set function? */
-		printf("no ctl_output for algo:%s\n", tp->cc_algo->name);
 		goto out;
 	}
 	if (ptr == NULL) {
@@ -618,7 +617,6 @@ rack_set_cc_pacing(struct tcp_rack *rack)
 	opt.val = rack->r_ctl.rc_saved_beta.beta;
 	error = CC_ALGO(tp)->ctl_output(tp->ccv, &sopt, &opt);
 	if (error)  {
-		printf("Error returned by ctl_output %d\n", error);
 		goto out;
 	}
 	/*
@@ -630,7 +628,6 @@ rack_set_cc_pacing(struct tcp_rack *rack)
 	opt.val = rack->r_ctl.rc_saved_beta.beta_ecn;
 	error = CC_ALGO(tp)->ctl_output(tp->ccv, &sopt, &opt);
 	if (error) {
-		printf("Error returned by ctl_output %d\n", error);
 		goto out;
 	}
 	/* Save off the original values for restoral */