From nobody Mon Nov 01 12:55:42 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id D5E831832CCE for ; Mon, 1 Nov 2021 12:55:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HjY1K5MK4z3sgR for ; Mon, 1 Nov 2021 12:55:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f54.google.com with SMTP id d27so10048787wrb.6 for ; Mon, 01 Nov 2021 05:55:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=xUf/cYQAZG8Cs4emnNwQA4q5TNsJ5Y3TE0G+zO4oYhE=; b=2VND38uaTUc7PZFr6B0llEb2rZIpacYTZusbkpPcW28O9/BwjOwDjyGNb0oS1ampQo LqqXRL/7Sb4kZbSq9jgcp7aeKFoNevXYHofptHIw9s75/c2SaelZ0ARBC+2QMoLx8LC/ MKQFMrlzZjEa5mNJVhbpKBs7xHHs4Mn5h54TMzOtRwjyjFBmyWTzqzJ7ab6CaxPyP6Oa O82jSQNiWhw64SuzPuwIV7L6ysrIKq5Wt4RXADTdTt+oxwaVp2Pq+eOpNzhLHspN5icc 1jJtqRWN3MLqX6ElREA1FHiqs1V+veUnUNFZ+kVNrf2vV2ByjeYvOwQ3HrEcEdy0HZFn BSbQ== X-Gm-Message-State: AOAM530/Kt1bWajLYs6Yba5XqvWgKHlMZIs56JdFASMhKX/ztLvLP/l3 VkSY6BPg3gIZTh0xVi8chsOa1A== X-Google-Smtp-Source: ABdhPJzdfx/rTm3McNnh+VV6e/6wDNinB9CU+ESgiW9Ltg10bb7T3F6N50oCC5Itb+Kc965EuBpP0w== X-Received: by 2002:a05:6000:2ca:: with SMTP id o10mr36801406wry.383.1635771343496; Mon, 01 Nov 2021 05:55:43 -0700 (PDT) Received: from smtpclient.apple (global-5-141.nat-2.net.cam.ac.uk. [131.111.5.141]) by smtp.gmail.com with ESMTPSA id j10sm3814696wru.15.2021.11.01.05.55.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Nov 2021 05:55:42 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.13\)) Subject: Re: git: e528757ca6a9 - main - iicoc: add support for SiFive HiFive Unmatched From: Jessica Clarke In-Reply-To: <202111010509.1A159OOo054720@gitrepo.freebsd.org> Date: Mon, 1 Nov 2021 12:55:42 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <3DD4AA9B-9985-4DFB-BBC8-E5E34787BA7A@freebsd.org> References: <202111010509.1A159OOo054720@gitrepo.freebsd.org> To: Philip Paeps X-Mailer: Apple Mail (2.3654.120.0.1.13) X-Rspamd-Queue-Id: 4HjY1K5MK4z3sgR X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N On 1 Nov 2021, at 05:09, Philip Paeps wrote: >=20 > The branch main has been updated by philip: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De528757ca6a9c03dca7e35b77411b311= af166b7f >=20 > commit e528757ca6a9c03dca7e35b77411b311af166b7f > Author: Thomas Skibo > AuthorDate: 2021-11-01 04:23:22 +0000 > Commit: Philip Paeps > CommitDate: 2021-11-01 04:26:49 +0000 >=20 > iicoc: add support for SiFive HiFive Unmatched >=20 > Reviewed by: jrtc27, philip > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D32737 I didn=E2=80=99t approve the revision, I just left comments on the first version. One of which still stands (not limiting the module to RISC-V). Jess > --- > sys/dev/iicbus/iicoc_fdt.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/sys/dev/iicbus/iicoc_fdt.c b/sys/dev/iicbus/iicoc_fdt.c > index 699a1738f53b..052174a91134 100644 > --- a/sys/dev/iicbus/iicoc_fdt.c > +++ b/sys/dev/iicbus/iicoc_fdt.c > @@ -55,6 +55,9 @@ __FBSDID("$FreeBSD$"); >=20 > static struct ofw_compat_data compat_data[] =3D { > { "opencores,i2c-ocores", 1 }, > + { "sifive,fu740-c000-i2c", 1 }, > + { "sifive,fu540-c000-i2c", 1 }, > + { "sifive,i2c0", 1 }, > { NULL, 0 } > }; >=20