From nobody Mon Nov 01 02:40:31 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0104A18378DA for ; Mon, 1 Nov 2021 02:40:43 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua1-x92a.google.com (mail-ua1-x92a.google.com [IPv6:2607:f8b0:4864:20::92a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HjHMZ5z1Zz3kty for ; Mon, 1 Nov 2021 02:40:42 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua1-x92a.google.com with SMTP id e2so29316711uax.7 for ; Sun, 31 Oct 2021 19:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=idIjZiIz+q+FX7mMgYEwOPjThaHYMb0fyNFuIraC/II=; b=ysnsF+evIV3nBz2EsgV0OQdTiuufl2WeaBMxq5BgnZjbwVhI6mlE8wlm8Ke4s4a3c5 M/fpF/XNbGDLAnjg0hImtDwXZduHxfoRTSa4BZapOa4WVVVebtfEjbpF2Ry5eETHFXFX /p58LxIhR7GV8PqoLRSec3FZ2e0korM22VrPhPdreBxujZjvZeJJLv0M2p1jlfGaSbn8 wSXTzhl9JU6xeSRpIFIRC9Emg7aPKMrDQehg7y9Zkbnp6th/87yxURlUVqwhf1YfNYP+ eMciKWJMUVx0t8sBJro+zysOpP+hl4eL8/W4bHkoViexQfQVR9WslP7LYU5DSltfyc0o zmxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=idIjZiIz+q+FX7mMgYEwOPjThaHYMb0fyNFuIraC/II=; b=Hk1/8lPj0XHISGl+Q4Fkfmnkq5LAPauTweccN9Efityzfg9bqw3TQEw1TWC3tdabyi bYqlzzuyuzK21swbGjoRgj5I8sb12uf/sDxQl+iN9r0RXAv3FydlySS741Mb4ZBcZM0K duzQyIXClVMtWe0Tzk5/ivZpYLspx1u8o4iPPByh2ohxO10cDlPdqj6tWBsMNip8xy1X thmYGr3ZFJBAZ+Faoq+ilc2t8Le8q1rd4DWPKz8Lq8IPANjAhKlEVDMn0vYwyxF+Ik2Z NifOsUZJfRW00o3erkgoYsI+FDUSaiisV1WsFGc6ge2T0/6oodGcBf6r+evzMVo1OjOh GB5A== X-Gm-Message-State: AOAM530JixZSJtVdI9qBtukoY+FiJ0Lhrpex8lDux8JB9a8UCR/mu+dM MZwg0Z2KPC4UXpTKn1OFu6KCRVt5iW4bviP6o536eg== X-Google-Smtp-Source: ABdhPJyAyxrkphwijiCWhF294KjHmL+yTBvf26QXxT4OdA4z5+CPX3e4U54U1aYU+FXYpgjZOuTCZk8F4j85NgILlXw= X-Received: by 2002:ab0:3d07:: with SMTP id f7mr4012209uax.11.1635734442241; Sun, 31 Oct 2021 19:40:42 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <20211021192020.6dcb95c1@ernst.home> <202110221704.19MH4FDn075994@gndrsh.dnsmgr.net> <20211022194717.8c94d2fa302339b55882497f@bidouilliste.com> <20211022225540.a4220cfddc96cc1e08cb5235@bidouilliste.com> In-Reply-To: From: Warner Losh Date: Sun, 31 Oct 2021 20:40:31 -0600 Message-ID: Subject: Re: git: 225639e7db68 - main - vt: Disable bell by default To: "Kevin P. Neal" Cc: Emmanuel Vadot , Benjamin Kaduk , "Rodney W. Grimes" , "Rodney W. Grimes" , Gary Jennejohn , Gleb Smirnoff , Slawa Olhovchenkov , src-committers , "" , dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000060818305cfb11a3d" X-Rspamd-Queue-Id: 4HjHMZ5z1Zz3kty X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-ThisMailContainsUnwantedMimeParts: N --00000000000060818305cfb11a3d Content-Type: text/plain; charset="UTF-8" On Sun, Oct 31, 2021 at 8:27 PM Kevin P. Neal wrote: > On Fri, Oct 22, 2021 at 10:55:40PM +0200, Emmanuel Vadot wrote: > > If I knew that this change would have caused that much mails I would > > have send a mail to current or whatever before and left the review > > opened for more time. > > Is this exposing an issue with the review process? I don't know the FreeBSD > review process, but I do know the LLVM one. Now, LLVM has a different set > of people in the project. That means that what works over there might not > be a good fit here. I thought I'd mention it just the same. > > > On the LLVM project they don't allow code that is up for review to be > pushed without an explicit signoff from one of the reviewers. Period. > > There's _no_ putting code up for review, waiting, and then going ahead and > pushing. > > If there's no feedback for a while the person asking for the review will > add a message every week or two that says just "ping". This often nudges > people to get to the review. Not always, and it can take a while to get > code through, but that's the process. > > Changes are allowed without a review if they are "obvious". If someone > pushes a change that another committer doesn't feel is obvious then the > change is reverted, usually by the person who cares. Personally, I've never > had this happen, but my non-review pushes are usually either new tests or > fixes to broken builds. > I clicked approve on this quickly after manu posted it. There was little other comment. Seemed like a boring change. A better review process wouldn't have helped. Dozens of other boring commits have a very similar profile. Warner --00000000000060818305cfb11a3d--