git: d10ea34d1128 - stable/12 - e1000: remove unused ifp backpointer
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Wed, 22 Dec 2021 13:44:48 UTC
The branch stable/12 has been updated by vmaffione:
URL: https://cgit.FreeBSD.org/src/commit/?id=d10ea34d1128571f99df29cc77bf5849d1661dd9
commit d10ea34d1128571f99df29cc77bf5849d1661dd9
Author: Vincenzo Maffione <vmaffione@FreeBSD.org>
AuthorDate: 2021-11-29 21:28:26 +0000
Commit: Vincenzo Maffione <vmaffione@FreeBSD.org>
CommitDate: 2021-12-22 13:44:39 +0000
e1000: remove unused ifp backpointer
The ifp (struct ifnet) backpointer in the e1000 private ifnet
data is not used anymore since the iflib transition.
Remove it so that developers are not tempted to use it and
get a NULL pointer dereference.
Reviewed by: markj, kbowling, erj
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D33157
(cherry picked from commit d91559564dc647846479824340bdf94b7cf98c05)
---
sys/dev/e1000/if_em.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/sys/dev/e1000/if_em.h b/sys/dev/e1000/if_em.h
index 9b34075ff2d9..4b087d3c2c05 100644
--- a/sys/dev/e1000/if_em.h
+++ b/sys/dev/e1000/if_em.h
@@ -441,7 +441,6 @@ struct em_rx_queue {
/* Our softc structure */
struct e1000_softc {
- struct ifnet *ifp;
struct e1000_hw hw;
if_softc_ctx_t shared;