Re: git: 40ccce5d1a85 - main - comms/mbelib: Fix building with CMake 4

On Mon, Sep 28, 2026 at 10:09 PM Mathieu Arnold <mat@freebsd.org> wrote:
>
> The rationale is that patches are clean, self contained, and easy to
> read, while sed commands end up being overly complicated, and people try
> to be clever, and then you need a PhD to understand what they actually
> do.
>
> The ports tree is for everyone, and anyone should be able to go and
> understand how a port work. A patch is simple, it means, this file needs
> some modification, and when that file changes, the patch either needs to
> be updated or removed. On the other hand, a sed line may end up being
> unreadable, and will gladly do nothing if the file has changed.
> Someone even had to invent a way to detect when a sed incantation does
> nothing any more and report it, because once a sed line is there, it
> never says it's wrong, it just sits there.

Thanks, I fully agree with all these points. Yet the sed invocation we're
talking about was readable and stable (in terms of applicability) enough
to my taste. If not the requirement, I'd go with Takefu's patch that simply
changes "do-patch" to "post-patch".