Re: git: 40ccce5d1a85 - main - comms/mbelib: Fix building with CMake 4

On Mon, Sep 28, 2026 at 07:28:40PM +0200, Daniel Engberg wrote:
> On 2026-09-28 19:17, Mathieu Arnold wrote:
> > On Mon, Sep 28, 2026 at 06:43:13AM +0000, Gleb Popov wrote:
> > > The branch main has been updated by arrowd:
> > > 
> > > URL: https://cgit.FreeBSD.org/ports/commit/?id=40ccce5d1a8540eef2e6a25f0f844fd23db0e755
> > > 
> > > commit 40ccce5d1a8540eef2e6a25f0f844fd23db0e755
> > > Author:     takefu <takefu@airport.fm>
> > > AuthorDate: 2026-09-28 06:31:38 +0000
> > > Commit:     Gleb Popov <arrowd@FreeBSD.org>
> > > CommitDate: 2026-09-28 06:31:38 +0000
> > > 
> > >      comms/mbelib: Fix building with CMake 4
> > >      PR:             298639
> > > ---
> > >   comms/mbelib/Makefile | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > > 
> > > diff --git a/comms/mbelib/Makefile b/comms/mbelib/Makefile
> > > index ce6ca4244291..5174aeef693a 100644
> > > --- a/comms/mbelib/Makefile
> > > +++ b/comms/mbelib/Makefile
> > > @@ -1,6 +1,7 @@
> > >   PORTNAME=	mbelib
> > >   DISTVERSIONPREFIX=	v
> > >   DISTVERSION=	1.3.0
> > > +PORTREVISION=	1
> > >   CATEGORIES=	comms hamradio
> > >   MAINTAINER=	takefu@airport.fm
> > > @@ -25,4 +26,7 @@ CMAKE_ON=	DISABLE_TEST
> > >   PLIST_FILES=	include/mbelib.h lib/libmbe.a lib/libmbe.so.1.0 \
> > >   		lib/libmbe.so.1 lib/libmbe.so
> > > +do-patch:
> > > +	${REINPLACE_CMD} 's|VERSION 2.6|VERSION 3.10|' ${WRKSRC}/CMakeLists.txt
> > > +
> > do-patch should never be overwritten, if you want to run sed to patch
> > files, do so in post-patch.
> > 
> > Also, running sed to patch files is only allowed when you replace the
> > content with something "variable" like ${PREFIX}.
> > 
> > This change should be a patch file, please fix.
> > 
> > Regards,
> There are more of "elaborate" hacks such as https://cgit.freebsd.org/ports/commit/?id=474e222c1fa7b512d55f11528848ee19d1260a62
> in the tree too

Well, because someone else already did something quite unreadable and
"elaborate" is not a license to do bad things too.

Please fix.

-- 
Mathieu Arnold