Re: git: e9dd473602a8 - main - science/fasthenry: update 3.0wr-021113 -> 3.0wr-031424

From: Gerald Pfeifer <gerald_at_pfeifer.com>
Date: Thu, 26 Mar 2026 18:15:45 UTC
On Tue, 24 Mar 2026, Rodrigo Osorio wrote:
>     Port changes:y
>         * move to gmake and GCC for the build, instead of trying to patch for llvm
:
> +USES=			gmake
> +USE_GCC=		yes

It might be helpful to add a comment explaining this.

And, frankly, looking at what you removed ...

> -#minimal changes to fix the clang build (there should be a more thorough
> -#clean-up, to correct types of functions, remove implicit declarations, fix
> -#formatting, add missing returns, etc.)
> -       @${REINPLACE_CMD} -e 's,return;,return 0;,' \

... this is not at all about Clang versus GCC per se. Rather it is about 
different versions of language standards their current defaults use.

In other words, I'm afraid this change offloads efforts to maintain this 
port to the poor folk(s) taking care of GCC on FreeBSD and USE_GCC=yes.

I would not be surprised if you just added two further problems to

  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292692
  [exp-run] Update GCC_DEFAULT to 15

Gerald