Re: git: 16eb147bebc3 - main - textproc/comparator: update to 2.14

Hi Daniel,

Am Mon, Mar 09, 2026 at 12:45:33AM +0100 schrieb Daniel Engberg:
> On 2026-03-08 23:25, Robert Clausecker wrote:
> > The branch main has been updated by fuz:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=16eb147bebc3b183c83c7ea32e1d576b727655a5
> > 
> > commit 16eb147bebc3b183c83c7ea32e1d576b727655a5
> > Author:     Robert Clausecker <fuz@FreeBSD.org>
> > AuthorDate: 2026-02-28 14:52:28 +0000
> > Commit:     Robert Clausecker <fuz@FreeBSD.org>
> > CommitDate: 2026-03-08 22:24:48 +0000
> > 
> >      textproc/comparator: update to 2.14
> >      This fixes a bug discovered on FreeBSD.
> >      Changelog: https://gitlab.com/esr/comparator/-/blob/master/NEWS.adoc?ref_type=heads
> > ---
> >   textproc/comparator/Makefile             |  6 ++++--
> >   textproc/comparator/distinfo             |  6 +++---
> >   textproc/comparator/files/patch-Makefile | 21 +++++----------------
> >   3 files changed, 12 insertions(+), 21 deletions(-)
> > 
> > ....
> > 
> > diff --git a/textproc/comparator/files/patch-Makefile b/textproc/comparator/files/patch-Makefile
> > index 9d1343fd0847..1c6f30d76325 100644
> > --- a/textproc/comparator/files/patch-Makefile
> > +++ b/textproc/comparator/files/patch-Makefile
> > @@ -1,22 +1,11 @@
> > ---- Makefile.orig	2026-02-10 12:32:33 UTC
> > +--- Makefile.orig	2026-02-28 14:41:28 UTC
> >   +++ Makefile
> > -@@ -15,8 +15,8 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST)
> > +@@ -15,7 +15,7 @@ SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST)
> >    EXTRAS  = shredtree.py shredcompare.py
> >    TEST    = test
> >    SOURCES = $(CODE) $(SCRIPTS) $(DOCS) $(EXTRAS) $(TEST) Makefile
> > --CFLAGS  = -O3
> > --LDFLAGS =
> > -+CFLAGS  ?= -O3
> > -+LDFLAGS ?=
> > +-CFLAGS  = -O3 -Wall -Wextra -Werror -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES
> > ++CFLAGS  += -O3 -Wall -Wextra -fstack-protector-strong -fno-strict-aliasing -DLARGEFILES
> > + LDFLAGS =
> Hi,
> 
> This now overrides flags set by ports framework which is a violation.
> https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags

Thank you for the reminder.  I will start an audit of my ports and adjust flags
in them as necessary as per policy.

Yours,
Robert Clausecker

-- 
()  ascii ribbon campaign - for an encoding-agnostic world
/\  - against html email  - against proprietary attachments