Re: git: 8bd89ab595cb - main - deskutils/qownnotes: the port had been updated to version 26.3.3

On Fri, Mar 06, 2026 at 05:50:56PM +0100, Daniel Engberg wrote:
> On 2026-03-06 08:05, Alexey Dokuchaev wrote:
> > The branch main has been updated by danfe:
> > 
> > URL: https://cgit.FreeBSD.org/ports/commit/?id=8bd89ab595cb9f03ab29068b1a0c08795d438781
> > 
> > commit 8bd89ab595cb9f03ab29068b1a0c08795d438781
> > Author:     Alexey Dokuchaev <danfe@FreeBSD.org>
> > AuthorDate: 2026-03-06 07:04:40 +0000
> > Commit:     Alexey Dokuchaev <danfe@FreeBSD.org>
> > CommitDate: 2026-03-06 07:04:40 +0000
> > 
> >      deskutils/qownnotes: the port had been updated to version 26.3.3
> >      Reduce vertical space to help Makefile maintainability by merging
> >      sporadic use of helpers and two per-flavor conditionals into one;
> >      drop needless default flavor assignment.
> You've now introduced more regressions (check portlint) and review
> https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using .
> Please fix your commit or back it out.

I'd like to address this calmly but clearly: the ports tree does not
have a single maintainer enforcing a unified style, and that's by
design. Committers are free to make reasonable stylistic choices within
their own ports, provided the result is correct and maintainable.

Helpers exist to assist. Their use is encouraged but not mandatory. In
some cases, explicit constructs are simply more readable, and that is a
legitimate trade-off that other contributors are entitled to make.

We would all appreciate it if this could be discussed as peers rather
than as a rule-setter and a rule-follower. Alexey already addressed the
concerns about a specific pattern that you had. Ultimately, style
decisions belong to the maintainer of each port, not to third-party
reviewers.

-- 
Mathieu Arnold