Re: git: 8bd89ab595cb - main - deskutils/qownnotes: the port had been updated to version 26.3.3

Hi Daniel,

Am Fri, Mar 06, 2026 at 08:27:24PM +0100 schrieb Daniel Engberg:
> On 2026-03-06 19:30, Alexey Dokuchaev wrote:
> > On Fri, Mar 06, 2026 at 05:50:56PM +0100, Daniel Engberg wrote:
> > > On 2026-03-06 08:05, Alexey Dokuchaev wrote:
> > > > commit 8bd89ab595cb9f03ab29068b1a0c08795d438781
> > > > 
> > > >   deskutils/qownnotes: the port had been updated to version 26.3.3
> > > >   Reduce vertical space to help Makefile maintainability by merging
> > > >   sporadic use of helpers and two per-flavor conditionals into one;
> > > >   drop needless default flavor assignment.
> > > 
> > > You've now introduced more regressions (check portlint) and review
> > > https://docs.freebsd.org/en/books/porters-handbook/book/#flavors-using .
> > > Please fix your commit or back it out.
> > 
> > There's nothing to fix, it looks exactly how I want it to look without
> > impeding future updates which I've been doing for past five years, as
> > de jure maintainer is inactive.  I believe I've provided sufficient
> > explanation in the commit log why I dislike scattering stuff belonging
> > to one flavor around several places.
> > 
> > I appreciate your attention to detail, but rigorously obeying lint tools
> > and general guidelines when they pessimize things more than do any good
> > is bad engineering practice.
> > 
> > ./danfe
> 
> If you're intentionally introducing more regressions into the tree it's
> clearly not going to in the right direction. Does that mean people can take
> over your ports whenever they feel like it?

Please remember that portlint warnings are warnings and not errors for
a reason.  What portlint recommends is more of a guideline than a hard
and fast rule, and committers can decide to go against these recommendations
if they believe that to be a reasonable choice.

Please stop badgering committers for violations of rules you have made up.
Adding a change that introduces a portlint warning is not a regression.

Yours,
Robert Clausecker

-- 
()  ascii ribbon campaign - for an encoding-agnostic world
/\  - against html email  - against proprietary attachments