git: 991ec6040be6 - main - sysutils/bareos24-server: Revert "Replace BROKEN to IGNORE_i386"
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 01 Feb 2026 17:57:01 UTC
The branch main has been updated by mandree:
URL: https://cgit.FreeBSD.org/ports/commit/?id=991ec6040be6586e5dedb2d240affbf08359ae73
commit 991ec6040be6586e5dedb2d240affbf08359ae73
Author: Matthias Andree <mandree@FreeBSD.org>
AuthorDate: 2026-02-01 17:41:39 +0000
Commit: Matthias Andree <mandree@FreeBSD.org>
CommitDate: 2026-02-01 17:52:56 +0000
sysutils/bareos24-server: Revert "Replace BROKEN to IGNORE_i386"
This reverts commit 6b84ea6ad1955a2bc13f17ddd3e0da66161f6506.
On platforms where ssize_t is 32 bits wide, the comparison will be made
unsigned (ssize_t converted to an unsigned value);
on platforms where ssize_t is wider than uint32_t, the comparison will
be made signed (uint32_t converted to the wider signed ssize_t).
That also has repercussions in that bytes_left a few lines down
will be negative if and only if the passed in size_t count argument is
greater than INT**_MAX, with ** being whatever size the "size_t count"
is.
If you don't see a compiler error on that line, that does not imply the
code is right or the bug is away, but that the compiler warning did not
trigger in that situation due to a warning bug. The upstream maintainer
did want the code break compile in that case.
Please take this upstream before reducing the effect of the BROKEN.
PR: 292852
---
sysutils/bareos24-server/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysutils/bareos24-server/Makefile b/sysutils/bareos24-server/Makefile
index 3659a0221781..720e0b801bc3 100644
--- a/sysutils/bareos24-server/Makefile
+++ b/sysutils/bareos24-server/Makefile
@@ -13,7 +13,7 @@ WWW= https://www.bareos.org/
LICENSE= AGPLv3 LGPL3
LICENSE_COMB= multi
-IGNORE_i386= data type bugs, "core/src/stored/backends/chunked_device.cc:685:13: error: comparison of integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka 'unsigned int')"
+BROKEN= data type bugs, "core/src/stored/backends/chunked_device.cc:685:13: error: comparison of integers of different signs: 'ssize_t' (aka 'int') and 'uint32_t' (aka 'unsigned int')"
CONFLICTS?= bareos22-server bareos23-server bareos-server