Re: git: f1236eb67474 - main - java/apache-commons-logging: pet stage-qa, get rid of "._*' metadata before installing

In reply to: Vladimir Druzenko : "Re: git: f1236eb67474 - main - java/apache-commons-logging: pet stage-qa, get rid of "._*' metadata before installing"
Go to: [ bottom of page ] [ top of archives ] [ this month ]

From: Vladimir Druzenko <vvd_at_freebsd.org>
Date: Tue, 30 Sep 2025 13:08:23 UTC

30.09.2025 15:35, Vladimir Druzenko пишет:
> 30.09.2025 12:12, Dima Panov пишет:
>> The branch main has been updated by fluffy:
>>
>> URL: 
>> https://cgit.FreeBSD.org/ports/commit/?id=f1236eb67474baa940bb30fe0d26c493d6702604
>>
>> commit f1236eb67474baa940bb30fe0d26c493d6702604
>> Author:     Dima Panov <fluffy@FreeBSD.org>
>> AuthorDate: 2025-09-30 09:00:38 +0000
>> Commit:     Dima Panov <fluffy@FreeBSD.org>
>> CommitDate: 2025-09-30 09:00:38 +0000
>>
>>      java/apache-commons-logging: pet stage-qa, get rid of "._*' 
>> metadata before installing
>>           Approved by:    portmgr blanket
>> ---
>>   java/apache-commons-logging/Makefile | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/java/apache-commons-logging/Makefile 
>> b/java/apache-commons-logging/Makefile
>> index 3ed1106b8be9..6ba44b395918 100644
>> --- a/java/apache-commons-logging/Makefile
>> +++ b/java/apache-commons-logging/Makefile
>> @@ -26,6 +26,9 @@ PORTDOCS=    *
>>     OPTIONS_DEFINE=    DOCS
>>   +post-extract:
>> +    @${FIND} ${WRKSRC} -name "._*" -delete
>> +
>>   do-install:
>>       ${INSTALL_DATA} ${WRKSRC}/${JARFILE} ${STAGEDIR}${JAVAJARDIR}
>>       ${LN} -sf ${JARFILE} ${STAGEDIR}${JAVAJARDIR}/${PORTNAME}.jar
>
> Hello!
>
> Why not something like this:
> EXTRACT_AFTER_ARGS=     --exclude ._* \
>                         --no-same-owner --no-same-permissions
> ?
> Also for not used in port files:
>                         --exclude .DS_Store \
>                         --exclude ${PORTNAME}-${DISTVERSION}-*.jar \
> commons-logging-1.3.5-adapters.jar
> commons-logging-1.3.5-api.jar
> commons-logging-1.3.5-javadoc.jar
> commons-logging-1.3.5-sources.jar
> commons-logging-1.3.5-test-sources.jar
> commons-logging-1.3.5-tests.jar
>
> P.S. This port need "more love":
> +LICENSE_FILE=  ${WRKSRC}/LICENSE.txt
>
> -PLIST_FILES=    %%JAVAJARDIR%%/${PORTNAME}.jar \
> -                %%JAVAJARDIR%%/${JARFILE}
> +PLIST_FILES=    ${JAVAJARDIR}/${PORTNAME}.jar \
> +                ${JAVAJARDIR}/${JARFILE}
>
> +        ${INSTALL_DATA} ${WRKSRC}/NOTICE.txt 
> ${WRKSRC}/RELEASE-NOTES.txt \
> +                ${STAGEDIR}${DOCSDIR}
>
https://bugs.freebsd.org/286425#c3

-- 
Best regards,
Vladimir Druzenko