Re: git: fd46b8c7f0d7 - main - filesystems/libblkid: fix odd reads and fdisk

Am 30.09.25 um 08:44 schrieb Gleb Popov:
> On Tue, Sep 30, 2025 at 2:49 AM Matthias Andree <mandree@freebsd.org> wrote:
>>
>> The branch main has been updated by mandree:
>>
>>      Could the port maintainer please check with the upstream what their
>>      stance on supporting non-GNU userspaces and non-Linux kernels is?
>>      Can we work with them to get such fixes upstreamed or will they turn
>>      us down because the tools are specifically called "util-linux"?
> 
> All right, I'll put this into my TODO, but no ETA, unfortunately.
> Thanks for digging this out anyways.

Hmmm... ok, they seem to have this clause in their 
Documentation/howto-contribute.txt: [1]

> Various Notes
> [...] 
> 	* patches relying on kernel features that are not in Linus Torvalds's
> 	  tree are not accepted.

[1] 
<https://github.com/util-linux/util-linux/blob/master/Documentation/howto-contribute.txt>

I would guess the FreeBSD kernel isn't in Linus Torvalds's tree...  so 
talking about the S_ISCHR() vs. S_ISBLK() changes I wonder if they would 
accept a refactoring patch that centralized that "is this device 
acceptable" check in once function and/or macro...  They have more or 
less copied those checks around to some places and having one clear 
blkid_validate_block_device() or similar might be acceptable and then 
we'd have to patch only one place for that purpose.

-- 
Matthias Andree
FreeBSD ports committer