Re: git: 1a2da0563af1 - main - devel/libblake3: New port: C library providing BLAKE3
Date: Sat, 13 Sep 2025 22:25:53 UTC
Hi, On Sat Sep 13, 2025 at 11:51 PM CEST, Daniel Engberg wrote: > On 2025-09-13 23:26, Ashish SHUKLA wrote: >> The branch main has been updated by ashish: >> >> URL:https://cgit.FreeBSD.org/ports/commit/?id=1a2da0563af14cc02aea7d1a95a4d4875618c40e >> >> commit 1a2da0563af14cc02aea7d1a95a4d4875618c40e >> Author: Ashish SHUKLA<ashish@FreeBSD.org> >> AuthorDate: 2025-09-13 21:05:26 +0000 >> Commit: Ashish SHUKLA<ashish@FreeBSD.org> >> CommitDate: 2025-09-13 21:13:23 +0000 >> >> devel/libblake3: New port: C library providing BLAKE3 >> >> ..... > > Hi, > > You get a warning with DEVELOPER=yes (this should always be enabled) Thanks for the reminder. I've added in make.conf(5). > > --- > You are using USE_GITHUB and WRKSRC is set which is wrong. Set GH_PROJECT > correctly or set WRKSRC_SUBDIR and remove WRKSRC entirely. > --- > Please use WRKSRC_SUBDIR as suggested > > CMAKE_ARGS+= -DBUILD_SHARED_LIBS:BOOL=true > Can be simplified by using CMAKE_ON= BUILD_SHARED_LIBS > > PLIST_SUB+= should be PLIST_SUB= > https://docs.freebsd.org/en/books/porters-handbook/book/#plist-sub Thank you for taking time to review. I've committed your advice in 1f7ef3369[0]. > It would also be nice if you could enable unit testing (make test) for > regression tests I'll look at implementing those later. References: [0] https://cgit.freebsd.org/ports/commit/?id=1f7ef336983804098848026088319fa215d93cf7 Thanks! -- Ashish "It could be that the purpose of your life is only to serve as a warning to others." (Asheligh Brilliant)