Re: git: ffaf09b17e05 - main - emulators/wine-devel: Update 10.13 => 10.14

08.09.2025 01:01, Gerald Pfeifer пишет:
> On Wed, 3 Sep 2025, Vladimir Druzenko wrote:
>> --- /dev/null
>> +++ b/emulators/wine-devel/files/patch-dlls_ntdll_unix_signal__x86__64.c
>> @@ -0,0 +1,11 @@
>> +--- dlls/ntdll/unix/signal_x86_64.c.orig	2025-08-29 19:56:01 UTC
>> ++++ dlls/ntdll/unix/signal_x86_64.c
>> +@@ -2061,7 +2061,7 @@ static inline BOOL check_invalid_gsbase( ucontext_t *u
>> +     else
>> +         arch_prctl( ARCH_GET_GS, &cur_gsbase );
>> + #elif defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
>> +-    amd64_get_gsbase( &cur_gsbase );
>> ++    amd64_get_gsbase((void **) &cur_gsbase);
>> + #elif defined(__NetBSD__)
>> +     sysarch( X86_64_GET_GSBASE, &cur_gsbase );
>> + #endif
> It generally is a good idea to describe the need for such a patch at the
> top of the file (together with its upstream status, which makes it easier
> to assess when doing later updates).
I didn't even think about it. If you think it's necessary, then it's 
probably worth doing.

> In this case I believe the issue does not trigger with a default system,
> rather only with a non-default GCC_DEFAULT=14?
>
> (If so, this would have been worth documenting as well.)
Yes, as described in comments: https://bugs.freebsd.org/289257#c1

> It also is a good idea to push local changes upstream. I did not see this
> here, and since I've had the same patch locally for a while (testing GCC
> development head building Wine) I took care of that now:
>
>     https://gitlab.winehq.org/wine/wine/-/merge_requests/8919
>
> Gerald

Thanks for report patch to upstream.

-- 
Best regards,
Vladimir Druzenko