From nobody Thu May 29 07:40:00 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b7JDh2mnYz5xvGg; Thu, 29 May 2025 07:40:04 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b7JDh1v7Wz40nf; Thu, 29 May 2025 07:40:04 +0000 (UTC) (envelope-from mat@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748504404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ieJdkhSqhZSvF4WQYQS36Gm7nTcQ1NwtE5f08jFHz2U=; b=seTx83CCas4qaiLsJliDWL46gYp65mmiQtLuib6ECPuIiN/JhZoiqiW/kqxbhT4zr4lpQK U/v7rKOE59if/M96a2xcMFHF4wunslQLILHxYOIxj8o0UCD6YoB0EbZfvcGpr7VEsvCiYd r1Au+H1AssLjl+1UEJnEQg4V7GknshqQvod15V9nGcDFG40Os0Z5afyxiAFxTxim+LOO2q 7YuuxSo7RSgpxJwYHtQH0Ide/1qfo6TUKz3VQNywp0PS/Fy7rOCt3sDzBiWtVT74oQvMrN U/CMdcQyT1c81l8YavE0QVPSinfmDyr5CyJLbrFh/NVwvs9ujd46wTg0GDgIMQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748504404; a=rsa-sha256; cv=none; b=o9NFo9yv5PYxkAX2fOrjuPml8cmtaClWswqN7qo+FWDzDk7bGn31EG/6eMGhmLBMjugKLf lDA5v8Cd/Z0CKt6HwEN/MIus+ZxlZFoA7oYDJwlN7sD12/mInk7GPLty2s2o1Ol26RsZq7 SaIQObXWGBjxEIP0iTnWK9gvQfISRqYOWZY91lCNWSB/zpjqStVv83ft6hwIbmrerBxcMz yBtGGaIRZq+bb26uyixmxB7gA9rmsIXsKQLoUsbjVGb5JZ6LQhhdDUyM3+QsOpeINHmyys rRnqV8H60vqWwJVgeDingu+tfUE4739NZNK1fyyfd5E1ogkVMEDszQZg+r3BJw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748504404; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ieJdkhSqhZSvF4WQYQS36Gm7nTcQ1NwtE5f08jFHz2U=; b=HDLq41VjugQUA/kdNf0baEUBR1B6T8ShSKKrGYzpELzY7oald62yBsa/JWdBweOk2J0+bT jNTnkeboedokyqDkf1rlNNGcyLPOvnu3hjrqEwbCya9KHcqeSduz5pBkGZFlBQuKRvgjWK pI/OR/9DTLFi8F36OGWHo45TLGikFlk9TxL9lK3xA9LG9GchXiAXqWVsHLMUIqdXxyaCzq S5ig2ZxPMTSbMmyK5JBoY+Bb9NkOjH2rNiLdmS6rWHDafSwvXgpUPbglHyP+73aijDUti8 1yUwjgXwwvfVIe8q6Y6t2l/NRaact/exrDTJ1+SfX92IFyaKEH1Jgb4T5KVtpQ== Received: from relay.mat.cc (eqx1.mat.cc [IPv6:2a01:678:2:200::49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "cow.mat.cc", Issuer "R11" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4b7JDh0T23zC5v; Thu, 29 May 2025 07:40:04 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mat-Laptop-13-AMD-Ryzen-7040Series (unknown [IPv6:2a01:e0a:836:f670:4933:218f:6d78:d879]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay.mat.cc (Postfix) with ESMTPSA id ACA4D2014F; Thu, 29 May 2025 09:40:01 +0200 (CEST) Date: Thu, 29 May 2025 09:40:00 +0200 From: Mathieu Arnold To: Xavier Beaudouin Cc: "ports-committers@freebsd.org" , "dev-commits-ports-all@freebsd.org" , "dev-commits-ports-main@freebsd.org" , 0mp@freebsd.org Subject: Re: git: f2d00f8fb185 - main - devel/jwt-cpp: A header only C++ library to JWT Message-ID: <37xf4cufojexndtjd47bawkkpri5bw4u2cjwzeg7q7wdixijsj@kektys3lvwji> References: <202505281254.54SCs8Vo042027@gitrepo.freebsd.org> <6eda7a13-51a5-4c3c-a9d8-93b5d3b152ab@FreeBSD.org> <56851C72-B510-4C74-9035-17B9076CAB93@freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5cwzwinqgszsni5m" Content-Disposition: inline In-Reply-To: <56851C72-B510-4C74-9035-17B9076CAB93@freebsd.org> --5cwzwinqgszsni5m Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 28, 2025 at 09:01:51PM +0200, Xavier Beaudouin wrote: >=20 >=20 > > Le 28 mai 2025 =E0 20:43, Xavier Beaudouin a =E9crit= : > >=20 > > Hello Daniel, > >=20 > >> Can you please review more carefully? > >>=20 > >> Any reason why upstream release archive isn't used? > >>=20 > >> https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-mast= er_sites-github > >>=20 > >> https://github.com/Thalhammer/jwt-cpp/releases/tag/v0.7.1 > >>=20 >=20 > Well, I may have not learnt the right way but : > PORTNAME=3D jwt-cpp > DISTVERSIONPREFIX=3D v > DISTVERSION=3D 0.7.1 > USE_GITHUB=3D yes > GH_ACCOUNT=3D Thalhammer >=20 > Should use the upstream archive from github, or is there something change= d? No, that will ask github to run git archive on tag v0.7.1 and generate a =2Etar.gz on the fly, as if you clicked on the "Source code" link on the tag page. What you should be using is the jwt-cpp-v0.7.1.tar.gz from that page. --=20 Mathieu Arnold --5cwzwinqgszsni5m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQITBAABCgB9FiEE9XJBpJetWizkEBUef2IOCp6dQb4FAmg4D09fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEY1 NzI0MUE0OTdBRDVBMkNFNDEwMTUxRTdGNjIwRTBBOUU5RDQxQkUACgkQf2IOCp6d Qb4oQgv6A3qcWYbYEH0fNauqat5eL6TQnyussLSn+wEoSD88Ahmt1CXNwkZv0wa1 PMwnbNSjErE6jBauLILpvHGY5enU4TtbC5eUndm9vVz0nx8TFpsDgnvYZEUGmI+P B05NL2pZ/08ftk81qOssxmdDbi08NA6kFeRX3iInipYqhNSfos7jCjFXtsejhJCV WPR0l8RalLUJ5KWVRa0kruePQekzawZA+dIfUplT/tgWNwNaa5G1PbKuPiT6Wis3 FKfUxLKgv4VtAToX6TFuVapnnMVg2zbwaMYiF3uPLWj9YbFnMy2U/xUwKZJatWCg hJCQneCB4cPL/u3M2EPi41bYbDkI2BepZwGVHFsePZpBQFwBPluH1KV1+fle7K30 9IPR9iPBXvFsoW7hnSwDW1Cu6js7LYuWqXQqLkgnQYjE7MnUe5vue9nGZRPtZJKc F3H0c7SjO1kww8R+MbRLG7dGklsdDvad+NReOtGpI/a7xRE9Vt7vHj9PZGqFhKDo muVhav00 =fjLz -----END PGP SIGNATURE----- --5cwzwinqgszsni5m--