From nobody Wed May 28 17:43:51 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b6xh84LZCz5x3Vk; Wed, 28 May 2025 17:44:08 +0000 (UTC) (envelope-from nobutaka@nobutaka.org) Received: from ik1-133-73045.vs.sakura.ne.jp (ik1-133-73045.vs.sakura.ne.jp [133.242.202.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4b6xh75rfgz3D43; Wed, 28 May 2025 17:44:07 +0000 (UTC) (envelope-from nobutaka@nobutaka.org) Authentication-Results: mx1.freebsd.org; none Received: from vm-home3.internal.nobutaka.org (unknown [60.87.149.0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ik1-133-73045.vs.sakura.ne.jp (Postfix) with ESMTPSA id B68568001C; Thu, 29 May 2025 02:43:52 +0900 (JST) DKIM-Filter: OpenDKIM Filter v2.11.0 ik1-133-73045.vs.sakura.ne.jp B68568001C Date: Thu, 29 May 2025 02:43:51 +0900 Message-ID: <86a56w8wbs.wl-nobutaka@freebsd.org> From: MANTANI Nobutaka To: Gerald Pfeifer Cc: SAKAI Hiroaki , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: ae1fa8dfcb88 - main - japanese/open_jtalk: New port In-Reply-To: <1ed4fa97-17e9-814c-bf9f-080531681cf5@pfeifer.com> References: <202505060600.54660GiJ019072@gitrepo.freebsd.org> <1ed4fa97-17e9-814c-bf9f-080531681cf5@pfeifer.com> User-Agent: Wanderlust/2.15.9 (=?UTF-8?B?QWxtb3N0IFVucmVhbA==?=) SEMI-EPG/1.14.7 (=?UTF-8?B?SGFydWU=?=) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (=?UTF-8?B?YW1kNjQtcG9ydGJsZC1mcmVlYnNkMTQuMg==?=) MULE/6.0 (=?UTF-8?B?SEFOQUNISVJVU0FUTw==?=) List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:7684, ipnet:133.242.0.0/16, country:JP] X-Rspamd-Queue-Id: 4b6xh75rfgz3D43 X-Spamd-Bar: ---- On Wed, 28 May 2025 04:59:30 +0900, Gerald Pfeifer wrote: > > On Tue, 6 May 2025, MANTANI Nobutaka wrote: > > The branch main has been updated by nobutaka: > > > > URL: https://cgit.FreeBSD.org/ports/commit/?id=ae1fa8dfcb88311ca952f7344135134a7d0abe09 > > > > commit ae1fa8dfcb88311ca952f7344135134a7d0abe09 > > Author: MANTANI Nobutaka > > AuthorDate: 2025-05-06 05:19:35 +0000 > > Commit: MANTANI Nobutaka > > CommitDate: 2025-05-06 05:59:53 +0000 > > > > japanese/open_jtalk: New port > > Do I read https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285959 > correctly that this new port was submitted by SAKAI Hiroaki? > > If so, please use `git commit --author="SAKAI Hiroaki the future to give proper credit. > > See Example 4 in our Committers Guide, > https://docs.freebsd.org/en/articles/committers-guide/ . Sorry, it was my mistake. I will add the author credit in the next patch submission from the maintainer. > > +USE_GCC= yes > > A question on the port, specifically: Why USE_GCC here? Does the port use > anything GCC-specific? Or does it fail to build with newer versions of > LLVM? If it's the latter, please go with > > USES=llvm:max=18 > > or similar instead. > > Thank you, > Gerald > I replaced USE_GCC=yes with USE_CXXSTD=c++14 (build failed with USES=llvm:max=18). Thanks, -- MANTANI Nobutaka nobutaka@freebsd.org, nobutaka@nobutaka.org