Re: git: ae1fa8dfcb88 - main - japanese/open_jtalk: New port

From: Gerald Pfeifer <gerald_at_pfeifer.com>
Date: Tue, 27 May 2025 19:59:30 UTC 
On Tue, 6 May 2025, MANTANI Nobutaka wrote:
> The branch main has been updated by nobutaka:
> 
> URL: https://cgit.FreeBSD.org/ports/commit/?id=ae1fa8dfcb88311ca952f7344135134a7d0abe09
> 
> commit ae1fa8dfcb88311ca952f7344135134a7d0abe09
> Author:     MANTANI Nobutaka <nobutaka@FreeBSD.org>
> AuthorDate: 2025-05-06 05:19:35 +0000
> Commit:     MANTANI Nobutaka <nobutaka@FreeBSD.org>
> CommitDate: 2025-05-06 05:59:53 +0000
> 
>     japanese/open_jtalk: New port

Do I read https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=285959 
correctly that this new port was submitted by SAKAI Hiroaki? 

If so, please use `git commit --author="SAKAI Hiroaki <kozos@kozos.jp"` in 
the future to give proper credit.

See Example 4 in our Committers Guide,
https://docs.freebsd.org/en/articles/committers-guide/ .


> +USE_GCC=	yes

A question on the port, specifically: Why USE_GCC here? Does the port use 
anything GCC-specific? Or does it fail to build with newer versions of 
LLVM? If it's the latter, please go with

  USES=llvm:max=18

or similar instead.

Thank you,
Gerald