Re: git: 40478d7acd2a - main - biology/bifrost: Unbreak build on 15-CURRENT

On 5/26/25 09:57, Gerald Pfeifer wrote:
> On Mon, 26 May 2025, Jason Bacon wrote:
>>> Did the build work with older versions of clang?
>> If USE_GCC is problematic, I'll just dig deeper and figure out how to
>> fix the build with clang19+.  In fact, we have a new volunteer with
>> strong C++ skills who might be able to solve this pretty quickly.
> 
>> Hayzam: You want to take a shot at this?
> 
> That would be awesome, thank you!
> 
> (USE_GCC itself is not problematic, especially if something really is
> GCC-specific. Just using it to work around clang getting stricter over
> time has often bitten us with loads of extra work and delays when then
> updating GCC_DEFAULT.)
> 
>> This also affects kallisto, which uses a bundled bifrost. I'd also like
>> to unbundle that, assuming their bundled copy doesn't contain any
>> special hacks.
> 
> Thumbs up. :-)
> 
> Thank you,
> Gerald

Updated bifrost and kallisto are committed.  The fix is a little fuzzy, 
since it involves an apparent typo, an invalid member name used in a 
template function that older compilers would not catch.  Pre-clang19, 
the error would only be caught at runtime after the template is 
instantiated, and even that was apparently rare (maybe the function is 
seldom called?).  I did several run tests of kallisto with the fix and 
found no differences in the output.

Hayzam came up with a DataStorage.tcc fix, and later found the same 
suggestion here:

https://github.com/pmelsted/bifrost/pull/18/files

-- 
Life is a game.  Play hard.  Play fair.  Have fun.