From nobody Tue May 27 06:04:29 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4b62CK1qYdz5wxHt; Tue, 27 May 2025 06:04:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4b62CK1Gtfz43BD; Tue, 27 May 2025 06:04:29 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748325869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jO46ReZwrVpHIqr+mehGPJrP0M8GMHSmCTpSz0FaZAM=; b=J9XHuYWvlTTa0HCLiSDD2+/HS0f5Alkwh6YXgGhB5t8KNv0sO0ziLfcQE34EkXhpsu7Fzz wu19bSUNEzeEIs6QPCOwbif6E96J6NuCdZkskSGlAJTe6H03NPzQ2ft6cfeh2H/cwEIkNb XgB+hixSnS0Hl5MJ3F7ARXC7Ri6AwTggjv8fqkfxvOmYJuAY5nNDrSDGNvifVP8now3hHv PQ+Biwn+rgs0LQia3eqpKGdpFBMlNb5FRmAe2qtoHOsVRHBGFHqrCbt3gjT2bsIQ1jdieD FD5FX+QUt4uAT72rpCfqpOMlOkfZJDAqH9sZrhSBIAyrKhe74wIQO93aDRBjgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748325869; a=rsa-sha256; cv=none; b=jvmkwmCgVoL3w4sBKj+ZiAQKQvDwVFPo5oN7COi21UnN1hirGy2IjspzLPdKO7Qy7PeD+1 CGsQYiWyEpiUr7aDfy1mNIAWSti71BbQ8pIAxa1v0SYntbKQ4zYNiAe7f0+1p4Y63pitrl FqTmBccDRQ/4nqmmpoge3ENVNEHYGmMjbQpXqlWiFNTjDI1KqEJ45K14RR3j7oqpeToZVz tsbEjts27S3o0BnFn2aeCMo+xi9l4SFh5wssT8+bFtcaPjoay3NETppK5qSK8bhR3wq0dJ VwTRX7wuDOVb9AM1UZ+mBf85vnGqfo7yV26AlV4Uw7RR88vw/axVN1aOXQJJbg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748325869; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jO46ReZwrVpHIqr+mehGPJrP0M8GMHSmCTpSz0FaZAM=; b=oOyClB18S5QK5nu45w45QWSnkGasQUtwDqduiv3wHZTMQXvqW6PghSKOjtarDzZKteV4m8 RUGVXhSfCYbiKyeCSdc426PfP2U1zrARc5qj19Of30CoJYLH/pFhRgzhDbfDtWY7N9zPvU WTYQDHB3a2ILk6WzRKUlVH3NK0+j94cgOf4sFjTGa+rzRUIytjUSlnCKgXnPSqY7r45eU4 pHs56Kw5nbM/5b+3KDIyDWMjeGfu+hjdsnuipnblXcngRCWLoBHnch5IWR/VGlAPh2EhNH spChd3+qNidr0gl9l+qKsMpp1Rmn9/QBkdkHJkz9sln/Qr/85iMWQ22Qs/ACYQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 106FA1492; Tue, 27 May 2025 06:04:29 +0000 (UTC) Date: Tue, 27 May 2025 06:04:29 +0000 From: Alexey Dokuchaev To: MANTANI Nobutaka Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 4e186c681084 - main - editors/microsoft-edit: New port, a console text editor written in Rust Message-ID: References: <202505261700.54QH0rn2007874@gitrepo.freebsd.org> List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202505261700.54QH0rn2007874@gitrepo.freebsd.org> On Mon, May 26, 2025 at 05:00:53PM +0000, MANTANI Nobutaka wrote: > commit 4e186c681084fc2996f98ed6927b2536bd13d495 > > editors/microsoft-edit: New port, a console text editor written in Rust > ... > +post-install: > + ${LN} -sf ${PREFIX}/bin/edit ${STAGEDIR}/${PREFIX}/bin/msedit There are several bugs in this line. First, symlink target should rarely be an absolute path (imagine mounting this filesystem under different path -- the link would get broken). Second, you don't need to specify any path at all as both source and target sit in the same directory. Third, for the same reason, you could hardlink instead and save an inode. Fourth, there is a superfluous slash between ${STAGEDIR} and ${PREFIX}. ./danfe