Re: git: 40478d7acd2a - main - biology/bifrost: Unbreak build on 15-CURRENT

On 5/26/25 01:48, Gerald Pfeifer wrote:
> On Thu, 15 May 2025, Jason W. Bacon wrote:
>>      biology/bifrost: Unbreak build on 15-CURRENT
>>      
>>      Unable to identify the cause, use GCC as a workaround for now
>>      No change on other FreeBSD versions
> :
>> +# Build fails with clang19, but succeeds with gcc13
>> +# Have not figured out where this sz_link member is even supposed to come from
>> +# DataStorage.tcc:81:69: error: no member named 'sz_link' in 'DataStorage<Unitig_data_t>'
>> +.if ${OSVERSION} > 1500000
>> +USE_GCC=	yes
>> +.endif
> 
> Did the build work with older versions of clang?
> 
> If so, can you please use that instead of USE_GCC=yes? The latter really
> is quite painful for those looking after the lang/gcc* ports where
> increasingly they (we) have to deal with a heap of broken ports when
> updating the default version of GCC.
> 
> Gerald

If USE_GCC is problematic, I'll just dig deeper and figure out how to 
fix the build with clang19+.  In fact, we have a new volunteer with 
strong C++ skills who might be able to solve this pretty quickly.

Hayzam: You want to take a shot at this?

https://github.com/pmelsted/bifrost/issues/90
https://github.com/outpaddling/freebsd-ports-wip/tree/master/bifrost

I looked into it briefly and didn't see an obvious solution, so I added 
USE_GCC as a temporary fix, so FreeBSD 15 would have a binary package in 
the interim.

This also affects kallisto, which uses a bundled bifrost. I'd also like 
to unbundle that, assuming their bundled copy doesn't contain any 
special hacks.

Thanks,

	J

-- 
Life is a game.  Play hard.  Play fair.  Have fun.