From nobody Tue May 13 17:38:04 2025 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZxkG73XX6z5vhFj; Tue, 13 May 2025 17:38:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta003.cacentral1.a.cloudfilter.net (omta001.cacentral1.a.cloudfilter.net [3.97.99.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZxkG72XDWz48Zh; Tue, 13 May 2025 17:38:07 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id EnSZuCjk19JM2EtZuupNsM; Tue, 13 May 2025 17:38:06 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id EtZsuaFY0JhBPEtZtuqjVM; Tue, 13 May 2025 17:38:06 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=6823837e a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=dt9VzEwgFbYA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=Uc7x6hbfent3y68vzPkA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 44FD6290; Tue, 13 May 2025 10:38:04 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 316A819A; Tue, 13 May 2025 10:38:04 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Daniel Engberg cc: Cy Schubert , Mathieu Arnold , Cy Schubert , ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 307e28238343 - main - sysutils/screen49: Fix fetch In-reply-to: <82b04ad4-5e23-42f9-837c-30e0facc3375@FreeBSD.org> References: <202505122206.54CM6iw6023619@gitrepo.freebsd.org> <20250512224827.25FA96B@slippy.cwsent.com> <20250513100830.0b2dae00@slippy> <82b04ad4-5e23-42f9-837c-30e0facc3375@FreeBSD.org> Comments: In-reply-to Daniel Engberg message dated "Tue, 13 May 2025 19:14:06 +0200." List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-main@freebsd.org Sender: owner-dev-commits-ports-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 13 May 2025 10:38:04 -0700 Message-Id: <20250513173804.316A819A@slippy.cwsent.com> X-CMAE-Envelope: MS4xfJA23hMi7qNLyQiQ3QIXUVKzf3IjuBH4Gtg3zHqDrP8TnPT3pXbdaLqQNhLpNEqVEl4UKw81VPEuDRn+bgVqvjByijbt08qlhMMDy6BD1lDynOtsod5X DbVt3ZuJln+v1HE0XZ2bWK/spfQ3Z/NTpYtCJBzx5j/MgwZcVI4zO2V9oemGvqu8fyUpirbE1BpzM7LIj916Z362CN0fIP33cm36DQyvJMTaLn7T8DTjNPD2 XcaCURGCLkrPnCuK/gr5bpwhOkTDesw0usKQ1lX03QzApYsnXy+0rneEYb8UrlEXgp5tLGX4zuAyBEp8trhyn/Jt4An2fEE/OF7uqA6r4NVnLHtLPUhSapX7 MFhw1YSy8mAYcNZw8zCIlh9Dsi5+rXmlNvTF3Nx1Kj1unf4u69o= X-Rspamd-Queue-Id: 4ZxkG72XDWz48Zh X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Spamd-Bar: ---- In message <82b04ad4-5e23-42f9-837c-30e0facc3375@FreeBSD.org>, Daniel Engberg w rites: > On 2025-05-13 19:08, Cy Schubert wrote: > > On Tue, 13 May 2025 18:53:08 +0200 > > Mathieu Arnold wrote: > > > >> On Mon, May 12, 2025 at 03:48:27PM -0700, Cy Schubert wrote: > >>> Their tarball doesn't include security patches. Security patches are > >>> included in their 4.9.1 branch but not in the tarball. > >>> > >>> Do you still want me to undo and mark the port FORBIDDEN? > >> > >> Please don't mark the port FORBIDDEN, the way you are getting the source > >> is just fine. > >> > > > > Too late for fetching source from upstream's git repo. diizzy@ > > objected. It was reverted and forbidden. Now reverted back and the > > patches have been imported directly into the port. It appears upstream > > will not tag a new point release. We can keep screen49 for now but > > it will be deprecated should there be any new unfixed CVEs. > > > > The screen meta-port now points to screen50. People wishing to use the > > old screen should install screen49. But they should plan on migrating > > to screen/screen50. Screen 5.0's hardstatus parser had been rewritten. > > It is no longer compatible with the previous hardstatus. Additionally > > there are some regressions. I have opened a couple of tickets with > > upstream regarding the regressions. Their parser doesn't work as they > > expect. > > > > Regardless, we must move forward. I would like to see screen49 removed > > at some point. > > > > Thanks, ideally it should be deprecated as soon as upstream stops > supporting it and you can also look at alternatives such as tmux, cu, > tio etc depending on your usecase. I didn't see any deprecation notice. The patches were applied to the screen-49 branch, as they were to the screen-50 branch. The screen-50 branch was tagged v.5.0.1. The screen-49 branch was not tagged with a new tag. We can assume quasi support for now. I don't know how long that will last. They don't make deprecation announcements. Only new release announcements. The fact that the patches were applied to the old branch but that it wasn't tagged may tell us that the bug was serious enough to backport it but not release a new 4.9. Probably best to deprecate it. I think we should deprecate it at the end of 2025Q3 then. > > Best regards, > Daniel I will add an UPDATING notice that the new hardstatus parser is somewhat broken. I will not accept PRs to fix upstream's code. I will cut and paste our PRs wrt the parser into upstream bug tickets. I don't know how well their parser was tested. I've done the best I could with our sample hardstatus. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0